Remove unnecessary flags in Legion CMake build #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag --root here is a workaround for buggy behavior in `pip install` where pip would ignore the --prefix setting when --global-option was supplied. As it turns out, --global-option is deprecated anyway so we removed in Legion. As a result, this is no longer required; the prefix is already set in the upstream project and the need for --root goes away with the removal of --global-option. See this Legion MR for details: https://gitlab.com/StanfordLegion/legion/-/merge_requests/1072
|
/ok to test |
manopapad
added
the
category:task
|
/ok to test |
manopapad
approved these changes
Jan 26, 2024
|
Editable and non-editable installs seem to work still on my local machine. Merging from main branch, to see if that fixes CI... |
manopapad
added a commit
to manopapad/legate.core
that referenced
this pull request
Feb 6, 2024
This reverts commit 5d74fdc.
manopapad
added a commit
that referenced
this pull request
Feb 6, 2024
manopapad
added a commit
to manopapad/legate.core
that referenced
this pull request
Feb 7, 2024
* Remove unnecessary flags in Legion CMake build. The flag --root here is a workaround for buggy behavior in `pip install` where pip would ignore the --prefix setting when --global-option was supplied. As it turns out, --global-option is deprecated anyway so we removed in Legion. As a result, this is no longer required; the prefix is already set in the upstream project and the need for --root goes away with the removal of --global-option. See this Legion MR for details: https://gitlab.com/StanfordLegion/legion/-/merge_requests/1072 * Make sure to use the latest Legion --------- Co-authored-by: Manolis Papadakis <[email protected]> Co-authored-by: Manolis Papadakis <[email protected]>
manopapad
added a commit
that referenced
this pull request
Feb 21, 2024
* Remove unnecessary flags in Legion CMake build (#932) * Remove unnecessary flags in Legion CMake build. The flag --root here is a workaround for buggy behavior in `pip install` where pip would ignore the --prefix setting when --global-option was supplied. As it turns out, --global-option is deprecated anyway so we removed in Legion. As a result, this is no longer required; the prefix is already set in the upstream project and the need for --root goes away with the removal of --global-option. See this Legion MR for details: https://gitlab.com/StanfordLegion/legion/-/merge_requests/1072 * Make sure to use the latest Legion --------- Co-authored-by: Manolis Papadakis <[email protected]> Co-authored-by: Manolis Papadakis <[email protected]> * Try adding back --root to see if it still works under ToT legion * Revert "Try adding back --root to see if it still works under ToT legion" This reverts commit d48ebec. * Bump Legion to get legion!1123 --------- Co-authored-by: Elliott Slaughter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag
--roothere is a workaround for buggy behavior inpip installwhere pip would ignore the--prefixsetting when--global-optionwas supplied. As it turns out,--global-optionis deprecated anyway so we removed in Legion. As a result, this is no longer required; the prefix is already set in the upstream project and the need for--rootgoes away with the removal of--global-option.See this Legion MR for details:
https://gitlab.com/StanfordLegion/legion/-/merge_requests/1072
I'm not sure which branch to send this patch to so if I'm set the wrong one, let me know and I'll update it.