Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantile Implementation #664

Merged
merged 138 commits into from
Aug 14, 2023
Merged

Quantile Implementation #664

Show file tree
Hide file tree
Changes from 74 commits
Commits
Show all changes
138 commits
Select commit Hold shift + click to select a range
3b1fae2
Quantile Python implementation and test.
aschaffer Oct 4, 2022
20f42a8
Merge branch 'nv-legate:branch-22.12' into fea_ext_py_quantiles
aschaffer Oct 6, 2022
0ab860f
Added boilerplate integration code for quantile.
aschaffer Oct 6, 2022
44ad1d3
fixed ceil() call
aschaffer Oct 10, 2022
c993cc7
Added 1st quantile pytest.
aschaffer Oct 10, 2022
c488ce2
Fixed 1st quantile pytest: added missing main.
aschaffer Oct 11, 2022
c9da113
Fixed global dtype to numpy.dtype.
aschaffer Oct 13, 2022
b166043
Replaced product() with numpy.product().
aschaffer Oct 13, 2022
c1a03cd
Debugging 'nearest'. Failed attempts, but some useful ways to simplif…
aschaffer Oct 17, 2022
192a3e5
Simplified 'nearest' implementation.
aschaffer Oct 18, 2022
eff4567
Fix for 'nearest' implementation.
aschaffer Oct 18, 2022
a8f7164
Added more quantile tests.
aschaffer Oct 18, 2022
f4bfd0c
Clean-up.
aschaffer Oct 19, 2022
5fdbaec
Merge branch 'nv-legate:branch-22.12' into fea_ext_py_quantiles
aschaffer Oct 20, 2022
13b99c5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 20, 2022
3fde15d
FIxed module.py formatting issues.
aschaffer Oct 24, 2022
2c98e09
FIxed test_quantiles.py formatting issues.
aschaffer Oct 24, 2022
13c544b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 24, 2022
3bda036
Merge branch 'branch-22.12' into fea_ext_py_quantiles
aschaffer Oct 26, 2022
2874aaa
Merge branch 'branch-22.12' into fea_ext_py_quantiles
aschaffer Oct 27, 2022
b368c75
Merge branch 'branch-22.12' into fea_ext_py_quantiles
aschaffer Oct 27, 2022
8a422c3
Merge branch 'branch-22.12' into fea_ext_py_quantiles
aschaffer Nov 1, 2022
aa6429d
Adrressed comments on re-using 'out' if given.
aschaffer Nov 1, 2022
e2c5b83
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 1, 2022
cd511aa
Merge branch 'branch-22.12' into fea_ext_py_quantiles
aschaffer Nov 2, 2022
265086c
Fixed 'out' management for scalar input.
aschaffer Nov 2, 2022
447ae39
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 2, 2022
57073b7
Fix for keepdims with multiple axes.
aschaffer Nov 4, 2022
607f785
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 4, 2022
ad6f4b4
Added tests to check for the supplied output case.
aschaffer Nov 4, 2022
13ce1bc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 4, 2022
0befed5
Added the keepdims = True case for out is not None. Caveat: there's a…
aschaffer Nov 7, 2022
541217e
Addressed comment on scalar input asarray().
aschaffer Nov 8, 2022
74bb77b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 8, 2022
8731c97
Addressed comment on scalar input np.asarray().
aschaffer Nov 8, 2022
9b8988f
Addressed comment on add_boilerplate.
aschaffer Nov 8, 2022
25e403c
Fixed LEGATE_MAX_DIM issues in tests.
aschaffer Nov 9, 2022
4a34ece
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 9, 2022
4a86262
Attempts to fix ndenumerate() approach.
aschaffer Nov 10, 2022
878a8dc
Attempts to fix ndenumerate() approach. More debugging.
aschaffer Nov 10, 2022
7ccd2c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 10, 2022
03e1495
Fixed ndenumerate, non-flattening approach.
aschaffer Nov 14, 2022
d69fa61
Clean-up (flake8).
aschaffer Nov 14, 2022
aba018b
Addressed comment on directly using qs_all for result.
aschaffer Nov 16, 2022
a9ce446
Addressed comment on input_is_scalar.
aschaffer Nov 16, 2022
92b3e11
Addressed comment on replacing take([pos],...) by just take(pos,...).
aschaffer Nov 16, 2022
b26eecc
Addressed comment on always using asarray(q).
aschaffer Nov 16, 2022
62daaad
Addressed comment on removing is_sorted() check.
aschaffer Nov 16, 2022
ef1323f
Addressed comment on more pythonic list comprehension in any().
aschaffer Nov 16, 2022
a0bd537
Addressed comment on using math.floor().
aschaffer Nov 16, 2022
5828710
Addressed comment on using sorted() instead of sort().
aschaffer Nov 17, 2022
d414d3f
Addressed comment on removing last 2 args, to be deprecated.
aschaffer Nov 17, 2022
c3b8d4c
Removed docstring on deprecated 'interpolation' arg.
aschaffer Nov 17, 2022
0b99e32
Addressed comment on qs_all[...].
aschaffer Nov 17, 2022
ea611a2
Addressed comment on in-place update of qs_all (avoids copies).
aschaffer Nov 18, 2022
5f29a86
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 18, 2022
fbe3c13
Addressed comment on overwrite_input test. Added.
aschaffer Nov 18, 2022
5afcaef
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 18, 2022
7d608a7
Addressed comment on using allclose().
aschaffer Nov 21, 2022
bb3d6f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2022
5a08250
Fixed keepdims=True failures.
aschaffer Nov 21, 2022
effb324
Addressed comment on adding multiple consecutive axes test, (0, 1).
aschaffer Nov 22, 2022
2a9d2af
Added test to debug axis=None case.
aschaffer Nov 29, 2022
cc7f476
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 29, 2022
d09f4a5
Partial fix for axis=None failures.
aschaffer Nov 29, 2022
b2445ab
Fix for axis=None failures.
aschaffer Nov 30, 2022
fed9344
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 30, 2022
4326bb8
Addressed review on not doing all(shapes).
aschaffer Nov 30, 2022
7fb1d6c
Addressed review on not returning empty tuple from in_place_interp().
aschaffer Nov 30, 2022
59e9acf
Added tests for random input.
aschaffer Dec 1, 2022
cbf8344
Addressed review on throwing on complex input.
aschaffer Dec 2, 2022
495d3ae
Addressed review on float128.
aschaffer Dec 2, 2022
f7fdf14
Addressed reviews on better replacement for in_place_interp() and usi…
aschaffer Dec 2, 2022
b0af955
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 2, 2022
aaf3e14
Addressed reviews on axes_set confusing apparent dependency on arr.sh…
aschaffer Dec 2, 2022
ac0478c
Completely removed the artificial dependency of axes_set to arr.shape.
aschaffer Dec 2, 2022
caf2f0c
Addressed comments on replacing np with num; fixed Weibull issue.
aschaffer Dec 5, 2022
b4f36a4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 5, 2022
d943147
Addressed comments on mypy function signatures: floor_i().
aschaffer Dec 5, 2022
daaa5af
Addressed comments on mypy function signatures: method functions.
aschaffer Dec 5, 2022
7e8dc31
Addressed comments on mypy function signatures: is_diff().
aschaffer Dec 5, 2022
dd1830f
Addressed comments on mypy function signatures: reshuffle_reshape().
aschaffer Dec 5, 2022
94a0368
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 5, 2022
2977462
Addressed comments on mypy function signatures: quantile_impl().
aschaffer Dec 6, 2022
b883e33
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 6, 2022
3e24afd
Addressed comments on mypy function signatures: quantile(). Tentative 1.
aschaffer Dec 6, 2022
6657451
Addressed comments on mypy function signatures: quantile(). Tentative…
aschaffer Dec 6, 2022
15a9875
Addressed comments on mypy function signatures: quantile(). Tentative…
aschaffer Dec 6, 2022
02a1be7
Addressed comments on mypy function signatures: quantile().
aschaffer Dec 6, 2022
15d764f
Addressed reviews on corner cases: quantile limits {0.0, 1.0}.
aschaffer Dec 7, 2022
645bcd7
Possible solution for the case of a <- scalar, list, or tuple. Attemp…
aschaffer Dec 8, 2022
dd2a187
Better solution for the case of a <- scalar, list, or tuple.
aschaffer Dec 8, 2022
d796bd3
Addressed review on testing output cast, but functionality awaits bug…
aschaffer Dec 9, 2022
5298c83
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 9, 2022
7924e2c
Addressed review on annotating a: ndarray and removing the asarray() …
aschaffer Dec 9, 2022
43fad06
Re-activated skipped test to, at least, run the output cast, w/o chec…
aschaffer Dec 10, 2022
d434bcd
Re-activated skipped output downcast test from float64 to float32 (ra…
aschaffer Dec 12, 2022
8957974
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 12, 2022
9203913
Merge branch 'branch-22.12' into fea_ext_py_quantiles
manopapad Dec 15, 2022
be00621
Merge branch 'branch-22.12' into fea_ext_py_quantiles
manopapad Dec 29, 2022
933a08e
Cosmetic changes
manopapad Dec 30, 2022
c89b98c
Use np instead of num
manopapad Dec 30, 2022
14dbdc1
Use num instead of cu
manopapad Dec 30, 2022
8339eee
Make sure all test input arrays are vanilla NumPy arrays
manopapad Dec 30, 2022
6d61b3f
Fix typing of axis
manopapad Dec 30, 2022
e092c67
Minor cleanups
manopapad Dec 30, 2022
58e112a
Clean up some comments
manopapad Dec 30, 2022
8f3a7fd
No need for helper method for tuple comparison
manopapad Dec 30, 2022
0910e14
Clean up docs
manopapad Dec 30, 2022
5f11788
Typo in docs
manopapad Dec 30, 2022
07becdf
Merge branch 'nv-legate:branch-22.12' into fea_ext_py_quantiles
aschaffer Jan 19, 2023
959e1eb
Fix for upper-bound quantile on averaged_interpolated_cdf.
aschaffer Jan 21, 2023
3f25522
Merge branch 'nv-legate:branch-23.03' into fea_ext_py_quantiles
aschaffer Feb 1, 2023
66f0967
Merge branch 'nv-legate:branch-23.03' into fea_ext_py_quantiles
aschaffer Mar 1, 2023
b104a56
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 1, 2023
fb53921
Merge branch 'nv-legate:branch-23.05' into fea_ext_py_quantiles
aschaffer Mar 8, 2023
a66f020
Added seeding to quantile tests.
Mar 9, 2023
e2c8967
Added percentile() main function.
aschaffer Mar 14, 2023
7d4ddc2
Percentile. Fix. Test failing.
aschaffer Mar 14, 2023
31b0431
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 14, 2023
c4cc576
Fixed args fwd-ing.
aschaffer Mar 14, 2023
62f19c6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 14, 2023
8bb35e1
Added profiling test for quantiles.
Mar 22, 2023
0e73dff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 22, 2023
5143b0c
Merge branch 'nv-legate:branch-23.05' into fea_ext_py_quantiles
aschaffer Mar 23, 2023
a73e8bb
Increased dimension of input array.
Mar 30, 2023
70e29e4
Fixed cupy failure with q.ndim > 1.
Apr 4, 2023
60a59ac
Refactored for performance.
aschaffer Apr 6, 2023
ecfaa2a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 6, 2023
43eb507
Merge branch 'nv-legate:branch-23.05' into fea_ext_py_quantiles
aschaffer Apr 18, 2023
1f20004
Merged branch-23.09.
aschaffer Jul 28, 2023
a2b61d9
Merge branch 'nv-legate:branch-23.09' into fea_ext_py_quantiles
aschaffer Aug 2, 2023
ac92a11
Merge branch 'nv-legate:branch-23.09' into fea_ext_py_quantiles
aschaffer Aug 3, 2023
acb43b0
Replaced deprecated np.product().
aschaffer Aug 11, 2023
45b6cfb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 11, 2023
b152207
Fixed typo in str_method.
aschaffer Aug 12, 2023
0996b86
Merge branch 'branch-23.09' into fea_ext_py_quantiles
manopapad Aug 14, 2023
3d8b84b
Fix pre-commit complaints
manopapad Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading