-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor scalar reductions to use common execution policy #573
Refactor scalar reductions to use common execution policy #573
Conversation
for more information, see https://pre-commit.ci
@jjwilke please add a copyright header to the new files |
left two nitpick-y comments. otherwise looks good. |
@magnatelee Should be ready to merge. There was an additional change required to unary_red_util.h you might want to glance at. |
#define CUDA_FUNCTION | ||
#endif | ||
|
||
#endif // SRC_CUNUMERIC_EXECUTION_POLICY_EXECUTION_POLICY_HELPERS_H_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline at end of file. Weird that the clang auto-formatter didn't catch that. Does it look like clang-format is running when you make change to header files? It might be that the filename pattern is skipping header files, or maybe just our clang-format configuration isn't checking for missing newlines at end of files.
Feel free to merge this once you remove the obsolete header file. |
Following the design doc for improving code reuse, this implements all scalar reduction kernels through a single implementation.