Fix for floating point predicates #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
* Fix the templates to instantiate correct variants for complex types * Add complex64 and float16 cases to tests for floating point predicates
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
* Fix the templates to instantiate correct variants for complex types * Add complex64 and float16 cases to tests for floating point predicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating point predicates were instantiating wrong variants for complex types. This PR fixes the issue, and also removes incorrect uses of
constexpr.