-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allclose detail + misc tests improvements #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
commented
Jul 18, 2022
bryevdv
commented
Jul 18, 2022
manopapad
reviewed
Jul 19, 2022
manopapad
reviewed
Jul 19, 2022
manopapad
reviewed
Jul 19, 2022
manopapad
reviewed
Jul 19, 2022
manopapad
reviewed
Jul 19, 2022
manopapad
reviewed
Jul 19, 2022
manopapad
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will be tackling #404 next, if you prefer to hold off on merging until that one, so you can switch to using cunumeric.atleast1d
in this same PR.
Thanks I will wait on #404! |
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
* rename tests_tools -> utils * parametrize window tests * remove superfluous asserts module * use utils.allclose * update test_view.py to AAA * parametrize unary ufunc tests * paramterize test_trilu.py * parametrize test_transform.py * simplify test_squeeze.py, update to AAA * Apply suggestions from code review * use ~close insead of not close * fix transpose test * formatting * typo * Update tests/integration/utils/comparisons.py
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
* rename tests_tools -> utils * parametrize window tests * remove superfluous asserts module * use utils.allclose * update test_view.py to AAA * parametrize unary ufunc tests * paramterize test_trilu.py * parametrize test_transform.py * simplify test_squeeze.py, update to AAA * Apply suggestions from code review * use ~close insead of not close * fix transpose test * formatting * typo * Update tests/integration/utils/comparisons.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started out to just improve
allclose
output, but grew to encompass a few other test improvements/simplications I have been meaning to get to:test_tools
toutils
. This makes it easier to distinguish from tests, and withpytest
it is just generally good to reserve the prefixtest_
exclusively for test modulesutils.asserts
module. In general it is better if helper functions only return results of some sort, and leave assertions to happen only in actual tests. I changed the tests that were using these functions to make their own assertions inside testsutils.comparison.allclose
has been added [1] that prints more detailed information about differences:diff_limit
is 5 but this can be increased or set to None for no limit.allclose
throughout.Commits are broken out discretely in case that is simpler to review.
[1] This new
allclose
usesnp.atleast_1d
so it would really be good to get the small PR #404 merged, if possible, before this one.