feat: generate Locale
type based on configuration
#3025
Merged
+101
−91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This changes type generation to narrow the
Locale
type to the configuredlocales
, this way functions that accept alocale
parameter (such as our composables) will have proper autocompletion for all configured locales.@kazupon
There's still an issue/quirk with the type, I'm don't know how to narrow the
locale
property on theComposer
type in the same way, so currently the following would cause a type error:Maybe you know how to resolve this? I don't think this should be merged while this issue is present 😅
Also working on this BobbieGoede#49.
📝 Checklist