Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate route types #49

Open
wants to merge 5 commits into
base: feat/locale-type-generation
Choose a base branch
from

Conversation

BobbieGoede
Copy link
Owner

@BobbieGoede BobbieGoede commented Jul 12, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Type generation to have type inference when passing unlocalized routes to i18n functions. There's still some weird behaviour with route name generation (before type generation) resulting in the /about route name.

Code_2024-07-12_23-16-27
Code_2024-07-12_23-16-43
Code_2024-07-12_23-17-07

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede changed the title feat: generate Locale type based on configuration feat: generate route types Jul 12, 2024
@kazupon
Copy link

kazupon commented Jul 14, 2024

Wow! It's amazing! πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants