Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw partial errors when failing to delete, forceDelete or restore a model #1420

Merged
merged 19 commits into from
Jul 17, 2020
Merged

Throw partial errors when failing to delete, forceDelete or restore a model #1420

merged 19 commits into from
Jul 17, 2020

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Jun 11, 2020 •
edited
Loading

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Resolves #1204

Changes

Breaking changes

No

@spawnia spawnia changed the title Failed delete Specify what happens on failed delete Jun 11, 2020
@spawnia spawnia added the discussion Requires input from multiple people label Jun 14, 2020
@spawnia spawnia added the enhancement A feature or improvement label Jul 6, 2020
@spawnia spawnia changed the title Specify what happens on failed delete Throw partial errors when failing to delete, forceDelete or restore a model Jul 6, 2020
@spawnia spawnia removed the discussion Requires input from multiple people label Jul 6, 2020
@lorado
Copy link
Collaborator

lorado commented Jul 6, 2020

I like it 👍

@spawnia spawnia merged commit db1a962 into master Jul 17, 2020
@spawnia spawnia deleted the failed-delete branch July 17, 2020 12:40
spawnia added a commit that referenced this pull request Jul 17, 2020
@spawnia
Throw partial errors when failing to delete, forceDelete or restore a…
a5b6e16 
… model (#1420)
@spawnia spawnia mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement A feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@delete directive does not return error when delete has failed through observer.
2 participants
@spawnia @lorado