Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable partial errors #1006

Closed
spawnia opened this issue Oct 11, 2019 · 2 comments
Closed

Enable partial errors #1006

spawnia opened this issue Oct 11, 2019 · 2 comments
Labels
enhancement A feature or improvement

Comments

@spawnia
Copy link
Collaborator

spawnia commented Oct 11, 2019

Is your feature request related to a problem? Please describe.

I ended up having a problem similar to #407 in our project.

We have a resolver that may return partially correct data, as well as some warnings. Right now, Lighthouse can either return data or errors, never both.

Describe the solution you'd like

I would like to be able to add errors to the result without stopping execution. We would have to add a mechanism that does not rely on Exceptions but rather allows to put errors in some kind of buffer that is collected before ending resolution.

@spawnia spawnia added the enhancement A feature or improvement label Oct 11, 2019
@joskfg
Copy link
Collaborator

joskfg commented Oct 14, 2019

That happens to me too. I'm calling an external graphql server from a graphql server, so the call could return some errors that I'd like to put in the output. #865 would help too.

@spawnia
Copy link
Collaborator Author

spawnia commented Aug 5, 2020

Resolved through #1420

@spawnia spawnia closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants