Fix subscriptions storage manager TTL #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict to the latest 5.5 & 7.x versions.
The TTL argument on cache calls is in minutes in Laravel 5.5-5.7 and changed to seconds on Laravel 5.8+, passing a Carbon instance makes sure our TTL in seconds is always correct.
stayallive
changed the title
|
How are they inconsistent? |
spawnia
reviewed
Apr 19, 2020
|
In Laravel But in So this way it is always in seconds (we document it is in seconds in the config file).
|
spawnia
pushed a commit
that referenced
this pull request
Apr 19, 2020
The TTL argument on cache calls is in minutes in Laravel 5.5-5.7 and changed to seconds on Laravel 5.8+, passing a Carbon instance makes sure our TTL in seconds is always correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added or updated testsAdded Docs for all relevant versionsUpdated CHANGELOG.md(not needed since changes are already described in Add TTL option for subscriptions storage #1284)Changes
This fixes the inconsistent cache TTL for Laravel
5.5-5.7/5.8+in the subscription storage manager introduced in #1284.We already use this code to do this in other cache related code in Lighthouse.
Also added the dependency on Carbon since we use that in this package directly, got the version constraints from the 5.5 and 7.x branch of
laravel/framework.Breaking changes
None. Changes are not released yet.