Add TTL option for subscriptions storage #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
changed the title
stayallive
changed the title
spawnia
reviewed
Apr 13, 2020
spawnia
reviewed
Apr 13, 2020
spawnia
reviewed
Apr 13, 2020
spawnia
reviewed
Apr 13, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds an optional TTL to the subscription storage manager that allows auto-cleanup of subscriptions.
If for some reason a webhook is missed it is nice to have a way to cleanup stale subscription to prevent broadcasting unneeded. Currently topics and subscribers are stored forever (and topics are never cleanup up, but that's for another day), this allows setting a TTL that will let the cache driver know when an item can be removed from storage.
Breaking changes
None.