[Ramachandran Sandhya] Duke Increments #13

sandydays · 2019-08-23T05:27:33Z

Add Week 2 iPs

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Add configuration for console applications

shiyao821

Very intuitive and generally easy to understand code.

To be done:

Documentation
Tests
Adding Ui, Parser, Storage, TaskList classes (as per Wk 3 requirements)
Level-9 find command

shiyao821 · 2019-09-03T06:31:56Z

src/main/java/Duke.java

+            } catch (DukeException ex) {
+                System.out.println(ex.getMessage());
+            } finally {
+                if (hasChanged) {


The current implementation of saving your tasks after every command is fine for now. However, this process may take a long time when the to-do list gets long. Perhaps save only when the 'bye' command is entered?

Hmm I think Sandy is right though. Specification from the [website](The specification on the website says ) - "Save the tasks in the hard disk automatically whenever the task list changes."

I think @shiyao821, your suggestion is definitely the more efficient one in terms of the number of times you write to your file in memory, but I guess as @larrylawl pointed out, the website seems to indicate otherwise. Right now, with all the GUI also set up, user can just hit the close button on the top right of the interface to exit from the application, and this can be problematic if we only save all changes to the task list when user enters command bye. So, I am going with writing the tasks in the file again each time the user changes the task list in any way.

shiyao821 · 2019-09-03T06:35:40Z

src/main/java/DateAndTime.java

+    protected String[] monthMappings = new String[]{"", "January", "February", "March", "April", "May", "June",
+                                                    "July", "August", "September", "October", "November", "December"};
+
+    public DateAndTime(String dateAndTime) {


Documentation on parse-able dateAndTime strings will help improve code readability

I now have included Javadoc comments in later commits!

shiyao821 · 2019-09-03T06:42:29Z

src/main/java/Duke.java

+
+        while (!userInput.equals("bye")) {
+            try {
+                String[] command = userInput.split(" ", 2);


This is smart.

shiyao821 · 2019-09-03T06:43:14Z

src/main/java/DateAndTime.java

@@ -0,0 +1,34 @@
+public class DateAndTime {


Very intuitive way of processing date and time. I like it! Moving on, checks should be made to prevent invalid date/time inputs from being processed eg. 13/16/19 2460

I like the effort that you have put in!
Just sharing another POV - you can use the built-in type Date (find out more here), instead of creating your own class.

I just realised the parsing of the date is also handled here. You can use the built in class SimpleDateFormat to parse input strings, and also output it in the format you want.

Eg on parsing

String format = "dd/MM/yyyy HHmm"; SimpleDateFormat readFormat = new SimpleDateFormat(format); readFormat.parse(//input string)

Thanks for the inputs!

shiyao821 · 2019-09-03T06:45:36Z

src/main/java/Event.java

+
+    public Event(String description, String at) {
+        super(description);
+        this.at = new DateAndTime(at);


What if the input given by the user is not an intended date and time? eg. (at: Block 903/904)?

I have tried to, in my more recent commits, ensure the date and time is of the correct format. I throw an exception if it is not!

shiyao821 · 2019-09-03T06:46:33Z

src/main/java/Event.java

+
+    @Override
+    public String toString() {
+        return "[E]" + super.toString() + " (at: " + at + ")";


Calling the super class toString() here is pretty smart. I've never thought of it.

larrylawl · 2019-09-03T16:47:11Z

src/main/java/DateAndTime.java

@@ -0,0 +1,34 @@
+public class DateAndTime {


I like the effort that you have put in!
Just sharing another POV - you can use the built-in type Date (find out more here), instead of creating your own class.

larrylawl · 2019-09-03T16:50:57Z

src/main/java/DateAndTime.java

@@ -0,0 +1,34 @@
+public class DateAndTime {


I just realised the parsing of the date is also handled here. You can use the built in class SimpleDateFormat to parse input strings, and also output it in the format you want.

Eg on parsing

String format = "dd/MM/yyyy HHmm"; SimpleDateFormat readFormat = new SimpleDateFormat(format); readFormat.parse(//input string)

larrylawl · 2019-09-03T16:52:50Z

src/main/java/Duke.java

+            } catch (DukeException ex) {
+                System.out.println(ex.getMessage());
+            } finally {
+                if (hasChanged) {


Hmm I think Sandy is right though. Specification from the [website](The specification on the website says ) - "Save the tasks in the hard disk automatically whenever the task list changes."

larrylawl · 2019-09-03T16:53:05Z

src/main/java/DukeException.java

@@ -0,0 +1,14 @@
+public class DukeException extends Exception {
+


Good effort on creating your own Duke Exception!

larrylawl · 2019-09-03T16:53:53Z

src/main/java/Event.java

+
+    @Override
+    public String toString() {
+        return "[E]" + super.toString() + " (at: " + at + ")";


Add assertions and fix minor bugs.

Improve code quality. Add more error handling.

…done by user, the next task is added to the task list. Up to user to delete any of the recurring tasks.

…ithout hiding any.

… display to method in MainWindow.java.

j-lum and others added 17 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request nus-cs2103-AY1920S1#12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)

Add configuration for console applications

a3ca5a4

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Merge pull request nus-cs2103-AY1920S1#13 from j-lum/javaexec

7b60e81

Add configuration for console applications

Add Greet, Echo, Exit functionality

e69c9ab

Add features of list of todos, adding to this list, and displaying list

ef37aab

Change printing slightly when user calls list

2fc2d29

Include mark as done functionality. Add Task.java.

be83aee

Add specific types of tasks - todos, deadlines, and events.

5aa6475

Add error handling.

c8a7312

Add removing tasks functionality. Include more cases of catching errors.

955bd04

Understand date and time for deadlines and events.

1a655db

Add saving and extracting data from hard disk.

fe83fe4

Merge branch 'branch-Level-7'

f7af50a

Merge branch 'branch-Level-8'

11a4067

shiyao821 reviewed Sep 3, 2019

View reviewed changes

nus-se-pr-bot added team.1 tutor.cchj1995 tutorial.CS2103-F10 labels Sep 6, 2019

Made code more OOP.

0c8926f

larrylawl reviewed Sep 7, 2019

View reviewed changes

larrylawl mentioned this pull request Sep 7, 2019

Feedback on week 4 project progress for larrylawl larrylawl/duke#3

Open

5 tasks

sandydays added 6 commits September 10, 2019 00:14

Rearrange files in packages.

c35a949

Add JUnit testing.

518f30e

Format code to adhere to Java coding standard

fb4e6af

Add Javadoc comments.

46ce9f3

Implemented finding tasks by keyword.

a0568ab

Merge branch 'branch-A-JavaDoc'

2e48b77

sandydays and others added 28 commits September 11, 2019 14:09

Merge branch 'branch-A-CodingStandard'

1c58f48

Merge all parallel branches for JavaDoc, CodingStandard, and Level-9.

a5d64ee

Merge branch 'gradle'

3d4a6db

Add gradle.

6833a4e

Include GUI.

4948608

Merge branch 'branch-Level-10'

204e9e6

Add assertions and fix minor bugs.

1afbefb

Merge pull request #3 from sandydays/branch-A-Assertions

fd9f3b1

Add assertions and fix minor bugs.

Improve code quality. Add more error handling.

476d6ea

Merge pull request #4 from sandydays/branch-A-CodeQuality

849dee5

Improve code quality. Add more error handling.

Add support for recurring tasks. Every time recurring task is marked …

e4373d5

…done by user, the next task is added to the task list. Up to user to delete any of the recurring tasks.

Change Label to Text Shape in FXML. Displays full list of tasks now w…

5f3c1e1

…ithout hiding any.

Remove hardcoded welcome message in fxml file. Change welcome message…

8287791

… display to method in MainWindow.java.

Add closing of window when user inputs bye command.

4d1febd

Add screenshot of duke app. Add app photo and description to title bar.

d3b4721

Update README.md with User Guide.

0430365

Modify User Guide.

2de0866

Set theme jekyll-theme-cayman

0303e10

Add shadowJar.

4fbc34d

Merge branch 'master' of https://github.com/sandydays/duke

72e772c

Add jar file for testing.

7f5dcbf

Make app platform independent.

e81c366

Update User Guide in right place.

3e73496

Set theme jekyll-theme-cayman

70b11e0

Add screenshot of app into User Guide.

4c23ce5

Merge branch 'master' of https://github.com/sandydays/duke

5f0653b

Correct printing of date and time of events and deadlines.

b4ac3d5

Fix warnings

d5f3b86

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ramachandran Sandhya] Duke Increments #13

[Ramachandran Sandhya] Duke Increments #13

sandydays commented Aug 23, 2019

shiyao821 left a comment •

edited

Loading

shiyao821 Sep 3, 2019

larrylawl Sep 3, 2019

sandydays Sep 18, 2019

shiyao821 Sep 3, 2019

sandydays Sep 18, 2019

shiyao821 Sep 3, 2019

sandydays Sep 18, 2019

shiyao821 Sep 3, 2019

larrylawl Sep 3, 2019

larrylawl Sep 3, 2019

sandydays Sep 18, 2019

shiyao821 Sep 3, 2019

sandydays Sep 18, 2019

shiyao821 Sep 3, 2019

larrylawl Sep 3, 2019

sandydays Sep 18, 2019

larrylawl Sep 3, 2019

larrylawl Sep 3, 2019

larrylawl Sep 3, 2019

larrylawl Sep 3, 2019

sandydays Sep 18, 2019

larrylawl Sep 3, 2019

		@@ -0,0 +1,14 @@
		public class DukeException extends Exception {

[Ramachandran Sandhya] Duke Increments #13

Are you sure you want to change the base?

[Ramachandran Sandhya] Duke Increments #13

Conversation

sandydays commented Aug 23, 2019

shiyao821 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shiyao821 left a comment •

edited

Loading