Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ng Qian Jie Cheryl] Duke Increments #9

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

[Ng Qian Jie Cheryl] Duke Increments #9

wants to merge 62 commits into from

Conversation

Yoshi275
Copy link

No description provided.

j-lum and others added 17 commits August 6, 2019 15:25
Ellieyee referenced this pull request in Ellieyee/duke Aug 23, 2019
@Ellieyee
Add Incorrect statement handling (#9)
be6901a 
* Add Exception comments

* Add case insensitivity feature

* Add IncorrectStatementException
tswuxia
tswuxia reviewed Sep 1, 2019
View reviewed changes
Copy link

@tswuxia tswuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good habit to commit code frequently! [like]

tswuxia
tswuxia reviewed Sep 1, 2019
View reviewed changes
Copy link

@tswuxia tswuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice that the coding style is followed strictly.

tswuxia
tswuxia reviewed Sep 1, 2019
View reviewed changes
Copy link

@tswuxia tswuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can implement the suggested classes like Parser and Storage to have more OOP.

@linyutinglyt
Copy link

Easy to read! Good coding style.

Yoshi275 and others added 16 commits September 9, 2019 08:01
@Yoshi275
Add shadowJar to gradle
6605a48
@Yoshi275
A-Assertions: Add Java assertions
5e6be98
@Yoshi275
A-CodeQuality: Enumerate Task and Command types, create InvalidComman…
1eab87e 
…d handler (#5)

* A-CodeQuality: Refactor invalid command handling to Parser class

* A-CodeQuality: Enumerate Task types
@Yoshi275
A-Travis: Add Travis CI (#6)
56a1d52 
* A-Travis: Set up Travis initially

* A-Travis: Fix build failure errors (checkStyleMain)

* A-Travis: Fix checkstyleMain detected styling errors

* A-Travis: Cache dependencies
@Yoshi275
Fix bugs
b9e285a
@Yoshi275
C-Sort: Create PQ and Comparator
1d211f8
@Yoshi275
C-Sort: Add sort by completion and deadline
9ae9065
@Yoshi275
C-Sort: Fix task completion info storage
902eee2
@Yoshi275
C-Sort: Fix checkstyle issues
9b6b06a
@Yoshi275
Merge pull request #8 from Yoshi275/C-Sort
cf9d196 
C-Sort: Add sorting feature
@Yoshi275
A-UserGuide: Update README and add screenshots
835655f
@Yoshi275
Merge pull request #9 from Yoshi275/A-UserGuide
8b638a9 
A-UserGuide: Update README and add screenshots
@Yoshi275
Set theme jekyll-theme-architect
106eb94
@Yoshi275
Change shadowJar to package dependencies
2cddd17
@Yoshi275
Create new file if list does not exist
d23b558
@Yoshi275
Merge branch 'master' of https://github.com/Yoshi275/duke
255e3d7
KartikeKhandelwal pushed a commit to KartikeKhandelwal/duke that referenced this pull request Sep 27, 2019
@j-lum
Merge pull request nus-cs2103-AY1920S1#12 from j-lum/gradle+x
0f4117f 
Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswuxia tswuxia tswuxia left review comments

Assignees
No one assigned
Labels
team.1 tutor.damithc tutorial.CS2103-T11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yoshi275 @linyutinglyt @tswuxia @nus-se-pr-bot @j-lum