-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cant install on python 3.8b1 on windows #13790
Comments
Did you use cython 0.29.10 which should fix that? |
Cython is run by the maintainer when packaging numpy, not when installing numpy. So the proper fix is making a new numpy release generated by the latest Cython. There is some discussion happening at https://bugs.python.org/issue37221 and https://bugs.python.org/issue37250 which may lead to a fix in CPython such that older Cython-generated code will continue working with Python 3.8. I'm in favor of that, but it's not clear whether that will be accepted. |
it is 0.29.10 |
This is happening a lot recently. I think the improvements to the packaging system make build-time requirements work in an acceptable fashion over the last year finally, so it may be time to consider shipping an sdist without generated sources. There are downsides too, but it's a discussion that would make sense to have. |
Rationale: it has happened multiple times in the recent past that users needed to use a more recent Cython than was used to generate the sdist of the most recent release available on PyPI (e.g. for building with a not-yet-released version of Python for which a Cython fix just landed). The dependency specification and packaging tools have matured to the point where it should be fine to require Cython to be installed. Also, we have wheels (and conda-forge packages) for Windows, Linux and macOS, so this change won't be visible at all to the average user. Closes numpygh-13790 Also adds pyproject.toml to MANIFEST.in, it was missing.
pip install numpy
The text was updated successfully, but these errors were encountered: