Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Tests not passing under windows and Python 3.8, h5py 2.9 #521

Closed
vasole opened this issue Jun 28, 2019 · 5 comments
Closed

[CI] Tests not passing under windows and Python 3.8, h5py 2.9 #521

vasole opened this issue Jun 28, 2019 · 5 comments
Assignees

Comments

@vasole
Copy link
Owner

vasole commented Jun 28, 2019

They are mainly HDF5 related tests.

image

@woutdenolf
Copy link
Collaborator

woutdenolf commented Jun 28, 2019

I installed python 3.8.0b1 but don't have wheels for numpy. I tried building from source but got errors. Also tried setting MSVC version manually without success:
"C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" x64 8.1 -vcvars_ver=15.9

How did you manage? This seems to be an unfixed issue:
numpy/numpy#13790

Anyway, I think it is an h5py API change:

except RuntimeError:

Try adding OSError:

    except (RuntimeError, OSError):

or alternatively:

    if name in parent:
        parent[name][()] = data
    else:
        parent[name] = data  

@vasole
Copy link
Owner Author

vasole commented Jun 28, 2019

You can download the relevant packages from

https://www.lfd.uci.edu/~gohlke/pythonlibs/

@vasole
Copy link
Owner Author

vasole commented Jun 28, 2019

I tried the above change without success. I think it is the handling of the temporary files.

@woutdenolf
Copy link
Collaborator

It fixes the issue for me (see PR, tested on window + py3.8).

@vasole
Copy link
Owner Author

vasole commented Jul 4, 2019

It seems I did a mistake somewhere. It fixes the problem for me too. Thanks.

@vasole vasole closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants