Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Remove minActiveDutyCycles and minPctActiveDutyCycles from spatial pooler #1178

Merged
merged 9 commits into from
Dec 11, 2016

Conversation

ywcui1990
Copy link
Contributor

Fixes: #1177
Depends on: #1174

@numenta-ci
Copy link

By analyzing the blame information on this pull request, we identified @scottpurdy, @mrcslws and @SaganBolliger to be potential reviewers

@ywcui1990
Copy link
Contributor Author

@mrcslws @scottpurdy This is ready for review.

I also have a question on nupic.bindings. After I made these changes, I did a clean installation. I am surprised to find that the parameter still exists in nupic.core/bindings/py/nupic/bindings/algorithms.py and it caused error on the NuPIC side (because the number of parameters don't match). I wonder why this occurs? Is this because when I install nupic.bindings, it didn't use my local nupic.core but fetched the latest release instead?

@ywcui1990
Copy link
Contributor Author

Problem solved after discussion with @mrcslws , it was because the parameter is named differently in nupic/bindings/algorithms.i and I failed to find it

@mrcslws mrcslws merged commit dae7f43 into numenta:master Dec 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants