This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Rename maxBoost to boostStrength #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ywcui1990-boostingRes
For permanances, use an EPSILON. For boosting, round the boost factor to a couple decimal places. Floating point differences have a larger effect on boosting because it's multiplicative.
Avoid floating point differences with C++ SpatialPooler
It's proving to be too difficult. So our options are: 1. Use shared C code to calculate boost factors and duty cycles for Python and C++ SpatialPoolers 2. Don't try to make them equal. Change the compatibility test to make sure the boost factor is right "enough", and then force them to be exactly equal, similar to what we already do with permanences. This change takes the second approach, which I think is the better approach.
Rather than using a mathy heuristic with an "arbitration" constant, explicitly handle the tie-break case. This mirrors a change in the C++ code. It's needed for compatibility.
|
By analyzing the blame information on this pull request, we identified @scottpurdy, @subutai and @baroobob to be potential reviewers |
Stop trying to get identical boost factors between py and cpp
…ding rules in boosting
|
@mrcslws The opf_checkpoint_test still fails with this PR with a segmentation fault. It looks like some backward compatibility tests failed due to the removal of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3422
Depends on:
#3411
numenta/nupic.core-legacy#1174
numenta/nupic.core-legacy#1178
Summary:
Note: this will be a breaking change.