Numaflow Controller Rollout Auto Healing #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the Numaflow Controller Deployment. Signed-off-by: Antonino Fugazzotto <[email protected]>
…ling (WIP) Signed-off-by: Antonino Fugazzotto <[email protected]>
afugazzotto
force-pushed
the
numaflowControllerRolloutAutoHeal
branch
from
88e5952
to
f8751a1
Compare
|
Need to fix merge conflict. |
Signed-off-by: Antonino Fugazzotto <[email protected]>
xdevxy
reviewed
Jun 24, 2024
juliev0
approved these changes
Jun 24, 2024
xdevxy
suggested changes
Jun 24, 2024
…ng unit tests to be more reusable. Signed-off-by: Antonino Fugazzotto <[email protected]>
xdevxy
approved these changes
Jun 25, 2024
darshansimha
referenced
this pull request
in darshansimha/numaplane
Jun 25, 2024
Signed-off-by: Antonino Fugazzotto <[email protected]> Signed-off-by: dsimha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Modifications
Enabled watching of Deployment resource in Numaflow Controller Rollout controller and updated unit test to test reconciliation logic.
Verification
Tested manually and via unit tests that making changes to the Deployment resource owned by the NumaflowControllerRollout will auto heal by undoing the changes.