Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto heal for NumaflowControllerRollout #19

Closed
Tracked by #16
xdevxy opened this issue May 29, 2024 · 1 comment · Fixed by #75
Closed
Tracked by #16

auto heal for NumaflowControllerRollout #19

xdevxy opened this issue May 29, 2024 · 1 comment · Fixed by #75
Assignees
@afugazzotto

Comments

@xdevxy
Copy link
Contributor

xdevxy commented May 29, 2024 •
edited
Loading

Watch() NumaflowController Deployment and related resources to trigger Reconcile() like we do with PipelineRollout and ISBServiceRollout. #6 is an improvements we can consider later.
@xdevxy xdevxy mentioned this issue May 29, 2024
Closed
3 tasks
@xdevxy xdevxy changed the title auto heal for NumaflowRolloutController auto heal for NumaflowControllerRollout May 29, 2024
@xdevxy xdevxy assigned dpadhiar and unassigned afugazzotto and dpadhiar May 29, 2024
@juliev0
Copy link
Collaborator

juliev0 commented May 30, 2024

#6 is an improvements we can consider later.

Hi @xdevxy. Can you clarify what makes this option too complicated? As far as I could tell, in the original code, there was a placeholder for that, no?

@xdevxy xdevxy assigned xdevxy and afugazzotto and unassigned xdevxy Jun 12, 2024
@afugazzotto afugazzotto mentioned this issue Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afugazzotto afugazzotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Numaflow Controller Rollout Auto Healing numaproj/numaplane
4 participants
@juliev0 @dpadhiar @xdevxy @afugazzotto