Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache children of Numaflow Controller Rollout twice #6

Open
juliev0 opened this issue May 28, 2024 · 2 comments
Open

Don't cache children of Numaflow Controller Rollout twice #6

juliev0 opened this issue May 28, 2024 · 2 comments

Comments

@juliev0
Copy link
Collaborator

juliev0 commented May 28, 2024

Currently, we are calling Watch() on Resources in NumaflowControllerRollout here but we also have these same resources being cached by the gitops-engine.

There is a call to clusterCache.OnResourceUpdated() in sync/cache.go. This uses a callback. We would need to make sure that we safely call the same reconciliation code that is being used by Reconcile(), such that only one NumaflowControllerRollout is being processed at a time. Thus, we would probably need to use a workqueue.RateLimitingInterface where both Reconcile() and this callback add to that queue (similar to what we're planning for PipelineRollout).

@juliev0 juliev0 changed the title Watch resources owned by the ControllerRollout so we can perform self-healing when somebody changes one of them Don't cache children of Numaflow Controller Rollout twice Jul 6, 2024
@juliev0
Copy link
Collaborator Author

juliev0 commented Jul 6, 2024

FYI @afugazzotto - there was an issue here before, but I updated it to better describe the issue

@juliev0
Copy link
Collaborator Author

juliev0 commented Aug 9, 2024

@dpadhiar Discussed with Hao that whenever you get freed up, this is one you could pick up

@dpadhiar dpadhiar self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants