fix: nc/isbservice rollouts will not wait for unowned pipelines to pause #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
dpadhiar
requested review from
xdevxy,
juliev0 and
afugazzotto
as code owners
juliev0
approved these changes
Sep 17, 2024
xdevxy
approved these changes
Sep 17, 2024
chandankumar4
pushed a commit
that referenced
this pull request
Sep 19, 2024
…use (#271) Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
Modifications
If dataLossPrevention is enabled and there are pipelines that are not owned by a PipelineRollout in a namespace, when updating a NumaflowController/ISBServiceRollout they would wait for this pipeline to pause that never would. This is because this pipeline is never told to pause (intended) and the controllers for each rollout just list pipelines in the namespace to watch.
We change this query for pipelines in the namespace to check that they are owned by a PipelineRollout:
Verification
Checked locally that updates on a NumaflowController and ISBService rollout both succeeded with a unowned pipeline existing in the namespace.