Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPND strategy needs to allow there to be Pipelines not owned by a PipelineRollout #245

Closed
juliev0 opened this issue Sep 11, 2024 · 2 comments · Fixed by #271
Closed

PPND strategy needs to allow there to be Pipelines not owned by a PipelineRollout #245

juliev0 opened this issue Sep 11, 2024 · 2 comments · Fixed by #271
Assignees
Labels
bug Something isn't working

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Sep 11, 2024

Describe the bug
Currently, NumaflowControllerRollout recociler presumes that any Pipelines in its namespace are owned by a PipelineRollout. ISBServiceRollout reconciler assumes that any Pipelines on the isbsvc are owned by a PipelineRollout as well.

They will wait for all of these Pipelines to pause; however any Pipeline not owned by a PipelineRollout will never be told this and so it will never pause.

Therefore, we should fix the calls (here and here) to only look for those which are labeled with a PipelineRollout label. (we need to add that label if it's not already there by the time this gets worked on)


Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

@juliev0
Copy link
Collaborator Author

juliev0 commented Sep 11, 2024

thought you may be able to help out with this one later @dpadhiar ?

@dpadhiar
Copy link
Contributor

thought you may be able to help out with this one later @dpadhiar ?

Ack, can take this up when I am finished with current tasks or time provides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants