Fix incorrect decoding of array when input contains more elements #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nullstyle |
|
@nebolsin great catch! Since @nullstyle is on sabbatical leave, let me organize a fork of this repo in |
|
Sorry, I havent checked in with github in a couple days. I think moving to a stellar managed fork makes the most sense as well @bartekn, thanks for arranging that. |
|
Cherry-picked into: stellar@0bc96f3. @nebolsin this can be closed. |
nebolsin
added a commit
to nebolsin/stellar-go
that referenced
this pull request
Sep 17, 2018
bartekn
pushed a commit
to stellar/go
that referenced
this pull request
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream issue: stellar/go#374.
Originally planned to work around it on stellar/go side (with stellar/go#597), but looks like the actual fix belongs here.