Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for actions/checkout@v4 with progress and filter #1298

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Nov 29, 2023

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@matkoch matkoch force-pushed the develop branch 5 times, most recently from 0231425 to d806295 Compare December 15, 2023 23:12
@Orgl9l
Copy link

Orgl9l commented Dec 29, 2023

@lahma - if you're planing on completing this pull request, please can you add in the ability to specificity a path: as part of the with: to action@checkout!

My use case is to check out multiple repos side-by-side per this However to achieve this I need to check out the base/standard repo to a parallel sub-path.

Such that the block look similar to this:

      - uses: actions/checkout@v4
        with:
          path: MySpecifiedBaseRepoPath

As past of this one also need to fix-up BuildCmdPath in GitHubActionsAttribute such that Run step with invoke the launch script build.cmd from that sub folder to find the Nuke project!

White I can create an sub class of GitHubActionsAttribute and override protected GitHubActionsJob GetJobs(GitHubActionsImage image, IReadOnlyCollection<ExecutableTarget> relevantTargets) to add additional steps - in this case to make additional steps to use actions/checkout@v4's for additional repos, it seem that I can't replace the existing GitHubActionsCheckoutStep as the underlying attribute fields are private and the Property getters are also locked down.

In the ideal case, it would be great to support more of the action@checkout properties, and have built-in support to perform additional checkouts for other repos that might be needed for the build including being able to specific the additional repos SSH secret (deploy key) such that you get blocks similar to this (the assumption is that both repos will have a similar branch):

      - name: checkout additional repo Org/AbcRepo
        uses: actions/checkout@v4
        with:
          repository: Org/AbcRepo
          ref: ${{ github.ref_name }}
          fetch-depth: 0
          ssh-key: ${{ secrets.REPO_SSH_SECRET }}
          path: MySpecifiedPath

I also hope that @matkoch is supportive of this addition.

Thanks!

@leorg99
Copy link

leorg99 commented Apr 11, 2024

@lahma @matkoch What is left to do so we can have this PR approved? I can help work on it. Is it just the one failing check and merge conflict?

@matkoch matkoch force-pushed the checkout-v4-with-progress branch from 6f46699 to 5ae0d6c Compare July 3, 2024 16:28
@matkoch matkoch merged commit bdb9287 into nuke-build:develop Jul 3, 2024
3 of 4 checks passed
@lahma lahma deleted the checkout-v4-with-progress branch July 3, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants