Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/checkout, actions/cache and actions/upload-artifact to @v4 in generated Github Actions to use Node 20 #1367

Closed
ebjornset opened this issue Apr 13, 2024 · 2 comments
Labels
Milestone

Comments

@ebjornset
Copy link

Usage Information

nuke.common 8.0.0, .Net 6/7/8

Description

Get this when running GitHub actions generated by nuke.common v 8.0.0:

1 warning
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Reproduction Steps

Generate a Github action that uses caching and upload some artifacts and run it on GitHub

Expected Behavior

No warnings

Actual Behavior

1 warning:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Regression?

No response

Known Workarounds

No response

Could you help with a pull-request?

Yes

@ebjornset ebjornset added the bug label Apr 13, 2024
@ebjornset
Copy link
Author

I just forked the repo and pulled down the code and noticed that its only actions/checkout left to update, since actions/cache and actions/upload-artifact is already updated to @v4 in develop

@lahma
Copy link
Contributor

lahma commented Apr 13, 2024

I just forked the repo and pulled down the code and noticed that its only actions/checkout left to update, since actions/cache and actions/upload-artifact is already updated to @v4 in develop

#1298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants