Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feat_select #38

Merged
merged 4 commits into from
Oct 30, 2024
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/helpers/json_to_predreq.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,6 @@ def decode(request):
task=request.model.task.lower(),
featurizer=featurizers,
)
if request.model["selectedFeatures"] != []:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work anymore, we have types now for the request, so now the request is not a dictionary but an object. Here's how we do it now:

Suggested change
if request.model["selectedFeatures"] != []:
if len(request.model.selected_features) > 0:

dataset.select_features(SelectionList=request.model["selectedFeatures"])
return dataset, jaqpot_row_ids
Loading