feat: feat_select #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnsaveus
commented
Oct 25, 2024
johnsaveus
commented
- PR After new jaqpotpy release with selected_features attribute
alarv
reviewed
Oct 29, 2024
alarv
requested changes
Oct 30, 2024
src/helpers/json_to_predreq.py
Outdated
| @@ -36,4 +36,6 @@ def decode(request): | |||
| task=request.model.task.lower(), | |||
| featurizer=featurizers, | |||
| ) | |||
| if request.model["selectedFeatures"] != []: | |||
There was a problem hiding this comment.
This won't work anymore, we have types now for the request, so now the request is not a dictionary but an object. Here's how we do it now:
Suggested change
| if request.model["selectedFeatures"] != []: | |
| if len(request.model.selected_features) > 0: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.