Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration parsing to allow api vrpProvider (avoid overriding … #1007

Closed
wants to merge 1 commit into from
Closed

Conversation

wibisono
Copy link

@wibisono wibisono commented Jan 6, 2023

I suppose this is one way to fix the issue reported here:
#1005

@massimocandela
Copy link
Member

I pushed a fix in dev for this. The overriding was happening because "api" was not recognized as a valid value. Let me know in the ticket if everything now works for you.

@wibisono
Copy link
Author

wibisono commented Jan 9, 2023

I pushed a fix in dev for this. The overriding was happening because "api" was not recognized as a valid value. Let me know in the ticket if everything now works for you.

Thanks, btw just noticed that the fix has API as the first value. There might still be issues later on if people put random vrpProvider, and instead of going back to default RPKI client, API becomes the default now.

But for what I need this is already working :)

@massimocandela
Copy link
Member

hey @wibisono, Immediately after pushing I realised the same and fixed it in the next commit: 02a39bd (and cleaned f2491ec)

@wibisono
Copy link
Author

wibisono commented Jan 9, 2023

Great, thank you for the fix & quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants