Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using api vrpProvider is considered invalid, it was reverted to default. #1005

Closed
wibisono opened this issue Jan 6, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@wibisono
Copy link

wibisono commented Jan 6, 2023

Hi,

I am trying to setup BGP alerter to read vrps from my own routinator instance, with the same config on the docs:

vrpProvider: api
url: http://127.0.0.1:8323/json
preCacheROAs: true

But I am getting the following error:

2023-01-06T13:49:30+00:00 error: The specified vrpProvider is not valid. Using default vrpProvider.

Tracing the error, it looks like api is not recognized as one of the valid providers, when bgp alerter is parsing the RPKI configurations.

Not sure how to patch it, maybe simplest is to recognized it as one possible providers in the rpki-validator helper, or change the logic in parsing this parameter.

Cheers,

@massimocandela
Copy link
Member

Hi @wibisono,

I hope all is good with you! Thanks for reporting this, at some point I refactored the validation of the provider parameter and I created this regression. It is now fixed in dev, it will go out with the next release.

@massimocandela
Copy link
Member

This is now in the pre-release v1.31.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants