fix/Locked but expired objects #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It waits #2526 but some changes will be also added. |
carpawell
force-pushed
the
fix/locked-but-expired-objects
branch
from
aef3c9d to
037ee9f
Compare
It will allow reusing that method in expiration checks. Signed-off-by: Pavel Karpy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2535 +/- ##
==========================================
+ Coverage 29.66% 29.91% +0.25%
==========================================
Files 405 405
Lines 30756 30880 +124
==========================================
+ Hits 9123 9239 +116
+ Misses 20863 20854 -9
- Partials 770 787 +17
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
Allow replication of any (expired too) locked object. Information about object locking is considered to be presented on the _container nodes_. Refs. nspcc-dev#2392. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/locked-but-expired-objects
branch
from
037ee9f to
9a4f7db
Compare
roman-khimov
reviewed
Sep 1, 2023
carpawell
force-pushed
the
fix/locked-but-expired-objects
branch
2 times, most recently
from
8ee6a17 to
ce5e8ce
Compare
roman-khimov
approved these changes
Sep 1, 2023
An object can be expired but locked (and not removed, of course). After the LOCK object expiration, the object should be unlocked and, therefore, become unavailable immediately not by the next GC cycle time. Closes nspcc-dev#2392. Signed-off-by: Pavel Karpy <[email protected]>
Locked objects are prohibited to be removed by a user operation so `Force` should be applied to the expired LOCK objects. Signed-off-by: Pavel Karpy <[email protected]>
See boltdb/bolt#428. Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/locked-but-expired-objects
branch
from
ce5e8ce to
48fbe5c
Compare
cthulhu-rider
approved these changes
Sep 8, 2023
vvarg229
added a commit
to vvarg229/neofs-testcases
that referenced
this pull request
Oct 6, 2023
…expired Unskiped test_expired_object_should_be_deleted_after_locks_are_expired, since the bug is fixed in commit nspcc-dev/neofs-node#2535 Signed-off-by: Oleg Kulachenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.