Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringified numbers in metabase keys #2540

Open
roman-khimov opened this issue Sep 1, 2023 · 0 comments
Open

Stringified numbers in metabase keys #2540

roman-khimov opened this issue Sep 1, 2023 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S2 Regular significance U4 Nothing urgent

Comments

@roman-khimov
Copy link
Member

Expected Behavior

No data type conversions for DB keys.

Current Behavior

Expiration bucket using stringified representation of epoch for keys. This leads to:

  • the need to strconv.FormatUint() to get the key and strconv.ParseUint() to retrieve it back (and it can return an error)
  • inability to iterate in some order of epochs starting from X

Possible Solution

8 bytes BE for the same thing, ordered, fixed size, conversion that can't fail.

Context

#2535.

Likely we have more cases like this in the metabase, please add comments.

@roman-khimov roman-khimov added neofs-storage Storage node application issues refactor labels Sep 1, 2023
@roman-khimov roman-khimov added enhancement Improving existing functionality U4 Nothing urgent S2 Regular significance I4 No visible changes and removed refactor labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S2 Regular significance U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

1 participant