Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce node version in SN attributes automatically #2455

Closed
roman-khimov opened this issue Jul 25, 2023 · 2 comments · Fixed by #2484
Closed

Announce node version in SN attributes automatically #2455

roman-khimov opened this issue Jul 25, 2023 · 2 comments · Fixed by #2484
Assignees
Labels
enhancement Improving existing functionality neofs-storage Storage node application issues
Milestone

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when I can't tell what node versions are being used on the network. We even have nspcc-dev/neofs-contract#299.

Describe the solution you'd like

We can have version in an attribute for now. Node can set it automatically, but allow to override via config (much like #602). These attributes should be documented appropriately.

@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-storage Storage node application issues labels Jul 25, 2023
@roman-khimov roman-khimov added this to the v0.39.0 milestone Jul 25, 2023
@roman-khimov roman-khimov modified the milestones: v0.39.0, v0.38.0 Aug 4, 2023
@carpawell carpawell self-assigned this Aug 7, 2023
@carpawell
Copy link
Member

but allow to override via config

What can it be useful for?

These attributes should be documented appropriately.

How (where) should the docs be placed? API? This repo? Is it gonna be another well-known attr?

@roman-khimov
Copy link
Member Author

What can it be useful for?

It's an attribute and in general it can't be checked server-side. Maybe there is some use case for overrides as well. But I mostly mean that if you set it in the config (just like any other attribute), it should win over the default value because that's the thing written in the config and expected to be used by admin.

How (where) should the docs be placed? API? This repo?

Everywhere. Node behavior should be documented for admin, API should be documented for API users.

Is it gonna be another well-known attr?

Yep, looks like this. It doesn't affect anything at the moment, yet at the same time it's very useful to have some admin-level visibility into the system.

carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 9, 2023
It is done automatically but can be overwritten if `Version` attribute is
provided via the application configuration.
Closes nspcc-dev#2455.

Signed-off-by: Pavel Karpy <[email protected]>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 9, 2023
It is done automatically but can be overwritten if `Version` attribute is
provided via the application configuration.
Closes nspcc-dev#2455.

Signed-off-by: Pavel Karpy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality neofs-storage Storage node application issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants