Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/Add version node attribute #267

Merged
merged 2 commits into from
Aug 9, 2023
Merged

feat/Add version node attribute #267

merged 2 commits into from
Aug 9, 2023

Conversation

carpawell
Copy link
Member

Relates nspcc-dev/neofs-node#2455.

@roman-khimov, @AliceInHunterland, @cthulhu-rider let's discuss the details:

  1. Should it have __NEOFS__ prefix?
  2. Should we add some preferable scheme? e.g. "you should add implementation language, build time, and version", etc

@carpawell carpawell self-assigned this Aug 8, 2023
cthulhu-rider
cthulhu-rider reviewed Aug 8, 2023
View reviewed changes
CHANGELOG.md
@@ -1,5 +1,10 @@
# Changelog

## [Unreleased]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff link would be nice

@cthulhu-rider
Copy link
Contributor

i'd start with unformatted attribute (otherwise dedicated field would be much more clear and easy-to-support)

@roman-khimov
Copy link
Member

  1. No
  2. No languages, no build times, just version. If you mean that we can have multiple implementations, that's true, but they would all have some names. So just a string (OK, ASCII printable) is OK.

@carpawell
Copy link
Member Author

Ready for review then.

@roman-khimov roman-khimov merged commit 953b4c5 into nspcc-dev:master Aug 9, 2023
@carpawell carpawell deleted the feat/add-version-node-attribute branch August 9, 2023 15:33
carpawell added a commit to carpawell/neofs-sdk-go that referenced this pull request Aug 15, 2023
@carpawell
netmap: Add version attribute setter
9d3628d 
A new well-known attribute is available after
nspcc-dev/neofs-api#267.

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell carpawell mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@AliceInHunterland AliceInHunterland Awaiting requested review from AliceInHunterland

Assignees

@carpawell carpawell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carpawell @cthulhu-rider @roman-khimov