netmap: Return same type from reading methods #273
Conversation
cthulhu-rider
added
documentation
cthulhu-rider
force-pushed
the
refactor/netmap
branch
from
5c02caf
to
0a71256
Compare
cthulhu-rider
requested review from
fyrchik,
carpawell,
alexvanin and
AnnaShaleva
| ) | ||
|
|
||
| // Node groups data related to NeoFS storage nodes registered in the NeoFS | ||
| // network. The information is stored in the current contract. | ||
| type Node struct { |
There was a problem hiding this comment.
If you're planning to update contract in the existing chain, then you need to write a migration routine. It should migrate the old netmap contract storage scheme to the new one (storageNode -> Node transformation), otherwise contract won't be able to work with the previously saved data.
There was a problem hiding this comment.
Yes, migration job should be performed, thanks.
I've started from documenting (for developers) the storage structure #276.
There was a problem hiding this comment.
We've decided to postpone the migration #277.
| switch state { | ||
| case NodeStateOffline: | ||
| removeFromNetmap(ctx, publicKey) | ||
| runtime.Log("remove storage node from the network map") |
There was a problem hiding this comment.
Why do you need these logs? There's a notification in the end of updateCandidateState, it should be enough.
There was a problem hiding this comment.
Maybe to distingush notification losses from non-throws. I don't mind to have such log messages.
cthulhu-rider
force-pushed
the
refactor/netmap
branch
4 times, most recently
from
8260152
to
425b08f
Compare
There is a need to return similar structure of information about the storage nodes from the contract storage readers. In previous implementation some methods didn't return node state which can differ with the one encoded in the node's BLOB. Define `Node` structure of the information about the storage nodes recorded in the contract storage. Return `[]Node` from all related methods. Also improve docs of touched contract methods. Signed-off-by: Leonard Lyubich <[email protected]>
Call changelog section with unreleased changes `Unreleased`. Also make it as a diff link. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
refactor/netmap
branch
from
425b08f
to
eef6e31
Compare
MAINTENANCEnode state #269I've changed format of the Netmap contract storage - should I do some compatibility actions? @fyrchik