Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netmap: Support MAINTENANCE node state #269

Closed
Tracked by #1680
cthulhu-rider opened this issue Sep 19, 2022 · 0 comments · Fixed by #271
Closed
Tracked by #1680

netmap: Support MAINTENANCE node state #269

cthulhu-rider opened this issue Sep 19, 2022 · 0 comments · Fixed by #271
Assignees
@fyrchik
Labels
enhancement Improving existing functionality good first issue Good for newcomers netmap Netmap contract related issue

Comments

@cthulhu-rider
Copy link
Contributor

There is a need to support one more value of node state enum - MAINTENANCE. In addition to adding a new constant, you need to look at how specific values are processed in contract methods.
@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality netmap Netmap contract related issue good first issue Good for newcomers labels Sep 19, 2022
This was referenced Sep 19, 2022
Closed
Merged
@fyrchik fyrchik mentioned this issue Sep 20, 2022
Merged
cthulhu-rider pushed a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 28, 2022
[nspcc-dev#269] netmap: Return same type from reading methods
0a71256 
There is a need to return similar structure of information about the
storage nodes from the contract storage readers. In previous
implementation some methods didn't return node state which can differ
with the one encoded in the node's BLOB.

Define `Node` structure of the information about the storage nodes
recorded in the contract storage. Return `[]Node` from all related
methods.

Also improve docs of touched contract methods.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider mentioned this issue Sep 28, 2022
Merged
cthulhu-rider pushed a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 30, 2022
@cthulhu-rider
[nspcc-dev#269] netmap: Return same type from reading methods
a1df597 
There is a need to return similar structure of information about the
storage nodes from the contract storage readers. In previous
implementation some methods didn't return node state which can differ
with the one encoded in the node's BLOB.

Define `Node` structure of the information about the storage nodes
recorded in the contract storage. Return `[]Node` from all related
methods.

Also improve docs of touched contract methods.

Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 30, 2022
@cthulhu-rider
[nspcc-dev#269] netmap: Return same type from reading methods
f8695c5 
There is a need to return similar structure of information about the
storage nodes from the contract storage readers. In previous
implementation some methods didn't return node state which can differ
with the one encoded in the node's BLOB.

Define `Node` structure of the information about the storage nodes
recorded in the contract storage. Return `[]Node` from all related
methods.

Also improve docs of touched contract methods.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 30, 2022
@cthulhu-rider
[nspcc-dev#269] netmap: Return same type from reading methods
0ad70a5 
There is a need to return similar structure of information about the
storage nodes from the contract storage readers. In previous
implementation some methods didn't return node state which can differ
with the one encoded in the node's BLOB.

Define `Node` structure of the information about the storage nodes
recorded in the contract storage. Return `[]Node` from all related
methods.

Also improve docs of touched contract methods.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 30, 2022
@cthulhu-rider
[nspcc-dev#269] netmap: Return same type from reading methods
1af936e 
There is a need to return similar structure of information about the
storage nodes from the contract storage readers. In previous
implementation some methods didn't return node state which can differ
with the one encoded in the node's BLOB.

Define `Node` structure of the information about the storage nodes
recorded in the contract storage. Return `[]Node` from all related
methods.

Also improve docs of touched contract methods.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit that referenced this issue Sep 30, 2022
@cthulhu-rider
[#269] netmap: Return same type from reading methods
d95bc53 
There is a need to return similar structure of information about the
storage nodes from the contract storage readers. In previous
implementation some methods didn't return node state which can differ
with the one encoded in the node's BLOB.

Define `Node` structure of the information about the storage nodes
recorded in the contract storage. Return `[]Node` from all related
methods.

Also improve docs of touched contract methods.

Signed-off-by: Leonard Lyubich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
enhancement Improving existing functionality good first issue Good for newcomers netmap Netmap contract related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support maintenance mode fyrchik/neofs-contract
2 participants
@fyrchik @cthulhu-rider