Feat/Add signature related status #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
realloc
previously approved these changes
Jun 17, 2022
fyrchik
reviewed
Jun 17, 2022
status/types.proto
Outdated
| // [**1026**] Signature verification failure. | ||
| // Details: | ||
| // - [**0**] Reason (big-endian 16-bit unsigned integer): | ||
| // - [**0**] Signature does not match. |
There was a problem hiding this comment.
Signature is invalid?
Also, what about failing to unmarshal public key?
There was a problem hiding this comment.
it was decided not to add details since it is not fully clear what format is ok. at least for now
Signed-off-by: Pavel Karpy <[email protected]>
Merged
fyrchik
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200.