Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signature-related status codes #200

Closed
cthulhu-rider opened this issue Feb 24, 2022 · 1 comment · Fixed by #225
Closed

Add signature-related status codes #200

cthulhu-rider opened this issue Feb 24, 2022 · 1 comment · Fixed by #225
Assignees
@carpawell
Labels
documentation Improvements or additions to documentation enhancement Improving existing functionality U3 Regular

Comments

@cthulhu-rider
Copy link
Contributor

Context

After #55 there are several signature schemes. As new schemes appear, network participants may not immediately support them, and therefore validate them. It would be useful to highlight this fact in the response status.

Possible solution

Collective status code relating to signatures SIGNATURE_VERIFICATION_FAIL. Reasons in detail:

  1. incorrect value;
  2. unsupported scheme.
@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality triage labels Feb 24, 2022
@cthulhu-rider cthulhu-rider modified the milestone: v2.13.0 Feb 24, 2022
@cthulhu-rider
Copy link
Contributor Author

Thoughts @realloc @fyrchik @carpawell @alexvanin

@cthulhu-rider cthulhu-rider added documentation Improvements or additions to documentation U3 Regular and removed triage labels May 12, 2022
@carpawell carpawell self-assigned this Jun 15, 2022
This was referenced Jun 16, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
documentation Improvements or additions to documentation enhancement Improving existing functionality U3 Regular
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/Add signature related status
2 participants
@carpawell @cthulhu-rider