core: use proper BaseExecFee and StoragePrice for interop context #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of the Blockchain's one leads to the same ExecFeeFactor within a single block. What we need is to update ExecFeeFactor after each transaction invocation, thus, cached DAO should be used as it contains all relevant changes.
We shouldn't use StoragePrice from Blockchain because its dao doesn't contain the whole set of changes from previouse transactions in the current block. Instead, we should use an updated storage price for each transaction and retrieve the price from cached DAO.
The InteropContext's one contains all relevant fee changes applied in the prevouse transactions of the current block.
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #2432 +/- ##
==========================================
+ Coverage 85.09% 85.18% +0.08%
==========================================
Files 289 289
Lines 36106 36119 +13
==========================================
+ Hits 30724 30767 +43
+ Misses 4098 4066 -32
- Partials 1284 1286 +2
Continue to review full report at Codecov.
|
roman-khimov
reviewed
Apr 8, 2022
For (bc *Blockchain).GetBaseExecFee().
|
Follows the neo-project/neo#2692 behaviour and can be merged. But CircleCI tests are failing due to timeout, not sure what's wrong with them. |
roman-khimov
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Outdated and non-unified BaseExecFee and StoragePrice values used for interop context pricing.
Solution
Merge.