Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fee in NativeContract.Invoke #2692

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix fee in NativeContract.Invoke #2692

merged 1 commit into from
Apr 13, 2022

Conversation

erikzhang
Copy link
Member

Fix #2690

shargon
shargon approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@superboyiii tested?

@ProDog
Copy link
Contributor

ProDog commented Apr 12, 2022

I used 3.2.0 and this PR to run two mainnet nodes, and the statedumper files are consistent.

@superboyiii
Copy link
Member

@superboyiii tested?

As @ProDog tested, it's OK since no such tx before in mainnet.

@erikzhang erikzhang changed the base branch from master to develop April 13, 2022 00:23
@erikzhang erikzhang merged commit da5decb into develop Apr 13, 2022
@erikzhang erikzhang deleted the fix-fee branch April 13, 2022 00:23
@AnnaShaleva AnnaShaleva mentioned this pull request Apr 14, 2022
Merged
@superboyiii superboyiii mentioned this pull request Apr 15, 2022
Closed
18 tasks
erikzhang added a commit that referenced this pull request Apr 18, 2022
@erikzhang
3.2.1 (#2694)
ed68274 
* Devhawk/getAddressVersion2 (#2689)

* Fix fee in NativeContract.Invoke (#2692)

* GetTransaction signers (#2685)

* Allow the committee to block a member from the committee (#2695)
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 19, 2022
@ixje
Fix storage price following neo-project/neo#2692
786599a
@ixje ixje mentioned this pull request Apr 19, 2022
Merged
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 19, 2022
@ixje
Fix storage price following neo-project/neo#2692 (#152)
d79adb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superboyiii superboyiii superboyiii approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExecFeeFactor and StoragePrice inconsistent usages
5 participants
@erikzhang @ProDog @superboyiii @shargon @AnnaShaleva