Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: restrict allowed Oracle callbacks #1625

Merged
merged 1 commit into from
Dec 17, 2020
Merged

core: restrict allowed Oracle callbacks #1625

merged 1 commit into from
Dec 17, 2020

Conversation

AnnaShaleva
Copy link
Member

Changes ported from neo-project/neo#2159.

We haven't the same problem with _deploy invocations, but we have a bug with Oracle callbacks.

@AnnaShaleva AnnaShaleva added the bug Something isn't working label Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #1625 (31b0690) into master (f2365e2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1625      +/-   ##
==========================================
+ Coverage   82.56%   82.58%   +0.01%     
==========================================
  Files         241      241              
  Lines       19100    19102       +2     
==========================================
+ Hits        15770    15775       +5     
+ Misses       2341     2338       -3     
  Partials      989      989              
Impacted Files Coverage Δ
pkg/core/native/oracle.go 81.64% <100.00%> (+0.17%) ⬆️
pkg/network/server.go 73.92% <0.00%> (+0.17%) ⬆️
pkg/rpc/client/wsclient.go 82.70% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2365e2...31b0690. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.92.0 milestone Dec 17, 2020
@roman-khimov roman-khimov merged commit c13d6ec into master Dec 17, 2020
@roman-khimov roman-khimov deleted the fix_oracle branch December 17, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants