Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CallFromNativeContract #2159

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Fix CallFromNativeContract #2159

merged 1 commit into from
Dec 17, 2020

Conversation

erikzhang
Copy link
Member

@erikzhang erikzhang commented Dec 17, 2020 •
edited
Loading

Fix #2158

@erikzhang erikzhang requested a review from devhawk December 17, 2020 01:36
devhawk
devhawk approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@devhawk devhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are there tests for this?

@superboyiii
Copy link
Member

image
image
I think it's OK.

@devhawk
Copy link
Contributor

devhawk commented Dec 17, 2020

@superboyiii but can the management contract call _deploy now?

@superboyiii
Copy link
Member

superboyiii commented Dec 17, 2020 •
edited
Loading

@superboyiii but can the management contract call _deploy now?

@erikzhang @devhawk call _deploy is OK, but GetSigners in Maktransaction always return WitnessScope.None which makes authorization failed in contract. If make transaction by SDK manually, it can be done. So it's another issue, but if we could solve it here is better.

@AnnaShaleva AnnaShaleva mentioned this pull request Dec 17, 2020
Merged
@shargon shargon merged commit d5b22f3 into master Dec 17, 2020
@shargon shargon deleted the fixes/CallFromNativeContract branch December 17, 2020 09:07
@devhawk
Copy link
Contributor

devhawk commented Dec 17, 2020

@superboyiii but can the management contract call _deploy now?

@erikzhang @devhawk call _deploy is OK, but GetSigners in Maktransaction always return WitnessScope.None which makes authorization failed in contract. If make transaction by SDK manually, it can be done. So it's another issue, but if we could solve it here is better.

For the scenario I was running, I don't think this will be an issue. I'll update monorepo and neo-express with this update today (USA time) and see if the get signers call is an issue. Will reopen or file a new issue if there is a problem

ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@erikzhang
Fix CallFromNativeContract (neo-project#2159)
3ac01df
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@erikzhang @cloud8little
Fix CallFromNativeContract (neo-project#2159)
cfa2dae
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
@ixje
https://github.com/neo-project/neo/pull/2159
bb825c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@devhawk devhawk devhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployment fails when there's a _deploy method
4 participants
@erikzhang @superboyiii @devhawk @shargon