Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix workspace init generator to workaround file rename issues in the tree #6098

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

leosvelperez
Copy link
Member

Current Behavior

When converting an Angular CLI workspace to an Nx workspace, if the conversion renames files that are also updated, the generation fails saying the file being updated doesn't exist. This due to an issue in the Angular CLI tree, a workaround is to create the file in the new path and remove the old one instead of renaming it.

Expected Behavior

Converting an Angular CLI workspace to an Nx workspace should work successfully.

Related Issue(s)

Fixes #5751

@leosvelperez leosvelperez self-assigned this Jun 22, 2021
@vercel
Copy link

vercel bot commented Jun 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/8Br95f3216ADasRmhaEmm25ChBbY
✅ Preview: Canceled

@nx-cloud
Copy link

nx-cloud bot commented Jun 22, 2021

Nx Cloud Report

CI ran the following commands for commit 67a2903. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --parallel --max-parallel=3
#000000 nx affected --target=e2e
#000000 nx affected --target=lint --parallel --max-parallel=4
#000000 nx affected --target=test --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez merged commit c66324d into nrwl:master Jun 22, 2021
@leosvelperez leosvelperez deleted the workaround-tree-rename branch June 22, 2021 16:50
mmuenker pushed a commit to mmuenker/nx that referenced this pull request Jun 28, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng add @nrwl/workspace fails in angular app
1 participant