Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng add @nrwl/workspace fails in angular app #5751

Closed
heddendorp opened this issue May 22, 2021 · 3 comments · Fixed by #6098
Closed

ng add @nrwl/workspace fails in angular app #5751

heddendorp opened this issue May 22, 2021 · 3 comments · Fixed by #6098
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@heddendorp
Copy link

Current Behavior

running ng add @nrwl/workspace leads to a fail like

Expected Behavior

The command should transform my project to a nx workspace

Steps to Reproduce

Run the command in https://github.com/heddendorp/tumi-app/tree/nx-workspace

Failure Logs

ERROR! apps/tumi-app-e2e/protractor.conf.js does not exist..
ERROR! apps/tumi-app-e2e/tsconfig.json does not exist..
ERROR! apps/tumi-app/src/app/components/index.ts does not exist..

Environment

>  NX  Report complete - copy this into the issue template

  Node : 14.16.1
  OS   : win32 x64
  yarn : 1.22.10

  nx : Not Found
  @nrwl/angular : Not Found
  @nrwl/cli : 12.3.4
  @nrwl/cypress : Not Found
  @nrwl/devkit : 12.3.4
  @nrwl/eslint-plugin-nx : Not Found
  @nrwl/express : Not Found
  @nrwl/jest : 12.3.4
  @nrwl/linter : 12.3.4
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : Not Found
  @nrwl/react : Not Found
  @nrwl/schematics : Not Found
  @nrwl/tao : 12.3.4
  @nrwl/web : Not Found
  @nrwl/workspace : 12.3.4
  @nrwl/storybook : Not Found
  @nrwl/gatsby : Not Found
  typescript : 4.1.5
@FrozenPandaz FrozenPandaz added the scope: angular Issues related to Angular support in Nx label May 22, 2021
@leosvelperez leosvelperez self-assigned this Jun 1, 2021
@leosvelperez
Copy link
Member

leosvelperez commented Jun 1, 2021

@heddendorp thanks for reporting this! I'll have a look at it to try to get it resolved.

Please note there is this guide to manually transition your Angular CLI workspace to an Nx workspace https://nx.dev/latest/angular/migration/migration-angular#transitioning-manually. You can follow the steps outlined there to unblock the migration if the fix is delayed.

@leosvelperez
Copy link
Member

The issue seems to be an Angular DevKit issue caused by files that are moved (renamed) and updated (overwritten). The Angular DevKit doesn't seem to be handling the new path of the moved files when validating the update operation. I created the following issue to try to get it resolved there: angular/angular-cli#21083. If a resolution is delayed, we'll add a workaround in our generator.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
3 participants