Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): delete src and e2e folders after transitioning to Nx from Angular #3990

Closed
wants to merge 1 commit into from

Conversation

mandarini
Copy link
Member

fix(angular): delete src and e2e folders after transitioning to Nx from Angular

ISSUES CLOSED: #3944

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #
#3944

@mandarini mandarini requested a review from juristr October 29, 2020 14:50
@nx-cloud
Copy link

nx-cloud bot commented Oct 29, 2020

Nx Cloud Report

CI ran the following commands for commit 84b3613. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=test --all --parallel 1/15/2021, 12:50:57 PM

Sent with 💌 from NxCloud.

@mandarini mandarini force-pushed the is3944 branch 2 times, most recently from d12c1b7 to 110820a Compare November 17, 2020 13:30
@mandarini
Copy link
Member Author

Keeps producing the following error:

 This should never happen. Path: "/src".

and

This should never happen. Path: "/e2e".

It happens when I try to delete the empty, now, directories, after converting an Angular CLI app to an Nx workspace. I am not sure how this can be solved.

@vsavkin
Copy link
Member

vsavkin commented Jan 9, 2021

@mandarini do you need any help with this?

@mandarini
Copy link
Member Author

@mandarini do you need any help with this?

Yes, I'll ask for help!

@mandarini
Copy link
Member Author

This PR will be closed. Deleting the folders proves to be a bit trickier than anticipated, since they are empty, and host cannot really perceive them. We could delete the folders via fs but this could create some ugly tests.

So, this PR will be closed for now (it may be revisited in the future). It is a small price to pay to delete once the remaining, empty, src and e2e folders. Since they are empty, they are not even added in git.

@mandarini mandarini closed this Jan 15, 2021
@mandarini mandarini deleted the is3944 branch March 18, 2022 14:48
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folders e2e and src are still there after migration to nx
2 participants