Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders e2e and src are still there after migration to nx #3944

Closed
meeroslav opened this issue Oct 20, 2020 · 2 comments
Closed

Folders e2e and src are still there after migration to nx #3944

meeroslav opened this issue Oct 20, 2020 · 2 comments
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@meeroslav
Copy link
Contributor

Current Behavior

After migrating angular CLI built application to NX, all code is migrated but original folders e2e/src and src/app, src/assets and src/environments are still there.

Expected Behavior

Original folders should be removed once the code is successfully migrated to apps and/or libs

Steps to Reproduce

ng new test123
cd test123
ng add @nrwl/workspace

This issue may not be prioritized if details are not provided to help us reproduce the issue.

Failure Logs

None

Environment

Node: 14.4.0
Angular CLI: 10.1.7
OS: OSX Catalina

@vsavkin vsavkin added the scope: angular Issues related to Angular support in Nx label Oct 23, 2020
@mandarini mandarini self-assigned this Oct 29, 2020
mandarini pushed a commit to mandarini/nx that referenced this issue Oct 29, 2020
mandarini added a commit to mandarini/nx that referenced this issue Nov 17, 2020
mandarini added a commit to mandarini/nx that referenced this issue Nov 17, 2020
mandarini added a commit to mandarini/nx that referenced this issue Jan 15, 2021
@mandarini
Copy link
Member

This PR will be closed. Deleting the folders proves to be a bit trickier than anticipated, since they are empty, and host cannot really perceive them. We could delete the folders via fs but this could create some ugly tests.

So, this PR will be closed for now (it may be revisited in the future). It is a small price to pay to delete once the remaining, empty, src and e2e folders. Since they are empty, they are not even added in git.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants