feat(js): update vue/node app and lib generators to support TS solutions #29299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Your CI Pipeline Execution ↗ for commit f1ebe93 ⏳ is in progress.
Last updated at 2024-12-12 20:24:50UTC Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
feat/vue-node-generators
branch
11 times, most recently
from
2698fdb to
a2521e4
Compare
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
074479a to
7d89b62
Compare
jaysoo
force-pushed
the
feat/vue-node-generators
branch
13 times, most recently
from
3bfea15 to
24c6ea1
Compare
jaysoo
force-pushed
the
feat/vue-node-generators
branch
3 times, most recently
from
cfa26af to
603091e
Compare
Coly010
approved these changes
Dec 12, 2024
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
603091e to
2e32362
Compare
jaysoo
commented
Dec 12, 2024
| @@ -0,0 +1,5 @@ | |||
| declare module '*.vue' { | |||
There was a problem hiding this comment.
This is needed because typecheck never worked without Volar in VSCode. The shims here at least makes it pass even though nothing meaningful is checked. We already do the same for Vue libs.
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
2e32362 to
855a35c
Compare
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
855a35c to
eec2cb1
Compare
packages/node/src/generators/e2e-project/files/ts-solution/tsconfig.json__tmpl__
Outdated
Show resolved
Hide resolved
jaysoo
force-pushed
the
feat/vue-node-generators
branch
2 times, most recently
from
02f8d62 to
b9b388b
Compare
Comment on lines
250
to
252
| "include": [ | ||
| ".nuxt/nuxt.d.ts", | ||
| ], |
There was a problem hiding this comment.
This is still relevant. We should not generate this include here.
| environment: 'jsdom', | ||
| include: ['src/**/*.{test,spec}.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'], | ||
| reporters: ['default'], | ||
| coverage: { reportsDirectory: '../coverage/my-lib', provider: 'v8' }, |
jaysoo
force-pushed
the
feat/vue-node-generators
branch
4 times, most recently
from
1f32a9b to
a728bb6
Compare
…-solution/tsconfig.json__tmpl__ Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
…ion.ts Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
a728bb6 to
5843dff
Compare
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
jaysoo
force-pushed
the
feat/vue-node-generators
branch
from
5843dff to
f1ebe93
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #