feat(js): update vue/node app and lib generators to support TS soluti…

…ons (#29299)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

---------

Co-authored-by: Leosvel Pérez Espinosa <[email protected]>

docs/generated/packages/express/generators/application.json

@@ -33,14 +33,17 @@
       "linter": {
         "description": "The tool to use for running lint checks.",
         "type": "string",
-        "enum": ["eslint"],
-        "default": "eslint"
+        "enum": ["eslint", "none"],
+        "default": "none",
+        "x-prompt": "Which linter would you like to use?",
+        "x-priority": "important"
       },
       "unitTestRunner": {
         "type": "string",
         "enum": ["jest", "none"],
         "description": "Test runner to use for unit tests.",
-        "default": "jest"
+        "default": "none",
+        "x-prompt": "Which unit test runner would you like to use?"
       },
       "tags": {
         "type": "string",

docs/generated/packages/nest/generators/application.json

@@ -37,13 +37,16 @@
         "description": "The tool to use for running lint checks.",
         "type": "string",
         "enum": ["eslint", "none"],
-        "default": "eslint"
+        "default": "none",
+        "x-prompt": "Which linter would you like to use?",
+        "x-priority": "important"
       },
       "unitTestRunner": {
         "description": "Test runner to use for unit tests.",
         "type": "string",
         "enum": ["jest", "none"],
-        "default": "jest"
+        "default": "none",
+        "x-prompt": "Which unit test runner would you like to use?"
       },
       "e2eTestRunner": {
         "type": "string",

docs/generated/packages/nest/generators/library.json

@@ -31,13 +31,17 @@
         "description": "The tool to use for running lint checks.",
         "type": "string",
         "enum": ["eslint", "none"],
-        "default": "eslint"
+        "default": "none",
+        "x-prompt": "Which linter would you like to use?",
+        "x-priority": "important"
       },
       "unitTestRunner": {
         "description": "Test runner to use for unit tests.",
         "type": "string",
         "enum": ["jest", "none"],
-        "default": "jest"
+        "default": "none",
+        "x-prompt": "Which unit test runner would you like to use?",
+        "x-priority": "important"
       },
       "tags": {
         "description": "Add tags to the library (used for linting).",

docs/generated/packages/node/generators/application.json

@@ -36,14 +36,26 @@
       "linter": {
         "description": "The tool to use for running lint checks.",
         "type": "string",
-        "enum": ["eslint"],
-        "default": "eslint"
+        "enum": ["eslint", "none"],
+        "default": "none",
+        "x-prompt": "Which linter would you like to use?",
+        "x-priority": "important"
       },
       "unitTestRunner": {
         "type": "string",
         "enum": ["jest", "none"],
         "description": "Test runner to use for unit tests.",
-        "default": "jest"
+        "default": "none",
+        "x-priority": "important",
+        "x-prompt": "Which unit test runner would you like to use?"
+      },
+      "e2eTestRunner": {
+        "type": "string",
+        "enum": ["jest", "none"],
+        "description": "Test runner to use for end-to-end tests",
+        "default": "none",
+        "x-priority": "important",
+        "x-prompt": "Which end-to-end test runner would you like to use?"
       },
       "tags": {
         "type": "string",
@@ -109,12 +121,6 @@
         "hidden": true,
         "x-priority": "internal"
       },
-      "e2eTestRunner": {
-        "type": "string",
-        "enum": ["jest", "none"],
-        "description": "Test runner to use for end to end (e2e) tests",
-        "default": "jest"
-      },
       "docker": {
         "type": "boolean",
         "description": "Add a docker build target"

docs/generated/packages/node/generators/library.json

@@ -36,14 +36,18 @@
       "linter": {
         "description": "The tool to use for running lint checks.",
         "type": "string",
-        "enum": ["eslint"],
-        "default": "eslint"
+        "enum": ["eslint", "none"],
+        "default": "none",
+        "x-prompt": "Which linter would you like to use?",
+        "x-priority": "important"
       },
       "unitTestRunner": {
         "type": "string",
         "enum": ["jest", "none"],
         "description": "Test runner to use for unit tests.",
-        "default": "jest"
+        "default": "none",
+        "x-prompt": "Which unit test runner would you like to use?",
+        "x-priority": "important"
       },
       "tags": {
         "type": "string",
@@ -69,7 +73,7 @@
       },
       "buildable": {
         "type": "boolean",
-        "default": false,
+        "default": true,
         "description": "Generate a buildable library.",
         "x-priority": "important"
       },

docs/generated/packages/nuxt/generators/application.json

@@ -22,24 +22,27 @@
         "pattern": "^[a-zA-Z][^:]*$",
         "x-priority": "important"
       },
-      "linter": {
-        "description": "The tool to use for running lint checks.",
-        "type": "string",
-        "enum": ["eslint"],
-        "default": "eslint"
-      },
       "skipFormat": {
         "description": "Skip formatting files.",
         "type": "boolean",
         "default": false,
         "x-priority": "internal"
       },
+      "linter": {
+        "description": "The tool to use for running lint checks.",
+        "type": "string",
+        "enum": ["eslint", "none"],
+        "default": "none",
+        "x-prompt": "Which linter would you like to use?",
+        "x-priority": "important"
+      },
       "unitTestRunner": {
         "type": "string",
         "enum": ["vitest", "none"],
         "description": "Test runner to use for unit tests.",
         "x-prompt": "Which unit test runner would you like to use?",
-        "default": "none"
+        "default": "none",
+        "x-priority": "important"
       },
       "e2eTestRunner": {
         "type": "string",

docs/generated/packages/vue/generators/application.json

@@ -54,12 +54,6 @@
           ]
         }
       },
-      "linter": {
-        "description": "The tool to use for running lint checks.",
-        "type": "string",
-        "enum": ["eslint", "none"],
-        "default": "eslint"
-      },
       "routing": {
         "type": "boolean",
         "description": "Generate application with routes.",
@@ -72,12 +66,21 @@
         "default": false,
         "x-priority": "internal"
       },
+      "linter": {
+        "description": "The tool to use for running lint checks.",
+        "type": "string",
+        "enum": ["eslint", "none"],
+        "default": "none",
+        "x-prompt": "Which linter would you like to use?",
+        "x-priority": "important"
+      },
       "unitTestRunner": {
         "type": "string",
         "enum": ["vitest", "none"],
         "description": "Test runner to use for unit tests.",
         "x-prompt": "Which unit test runner would you like to use?",
-        "default": "vitest"
+        "default": "none",
+        "x-priority": "important"
       },
       "inSourceTests": {
         "type": "boolean",

docs/generated/packages/vue/generators/library.json

@@ -36,13 +36,17 @@
         "description": "The tool to use for running lint checks.",
         "type": "string",
         "enum": ["eslint", "none"],
-        "default": "eslint"
+        "default": "none",
+        "x-prompt": "Which linter would you like to use?",
+        "x-priority": "important"
       },
       "unitTestRunner": {
         "type": "string",
         "enum": ["vitest", "none"],
         "description": "Test runner to use for unit tests.",
-        "x-prompt": "What unit test runner should be used?"
+        "x-prompt": "What unit test runner should be used?",
+        "default": "none",
+        "x-priority": "important"
       },
       "inSourceTests": {
         "type": "boolean",

e2e/eslint/src/linter.test.ts

@@ -772,7 +772,7 @@ describe('Linter', () => {
       const mylib = uniq('mylib');
 
       runCLI(
-        `generate @nx/node:app --name=${myapp} --linter eslint --directory="." --no-interactive`
+        `generate @nx/node:app --name=${myapp} --linter=eslint --directory="." --e2eTestRunner=jest --no-interactive`
       );
       runCLI('reset', { env: { CI: 'false' } });
       verifySuccessfulStandaloneSetup(myapp);

e2e/jest/src/jest.test.ts

@@ -141,7 +141,7 @@ describe('Jest', () => {
   it('should be able to test node lib with babel-jest', async () => {
     const libName = uniq('babel-test-lib');
     runCLI(
-      `generate @nx/node:lib libs/${libName} --buildable --importPath=@some-org/babel-test --publishable --babelJest`
+      `generate @nx/node:lib libs/${libName} --buildable --importPath=@some-org/babel-test --publishable --babelJest --unitTestRunner=jest`
     );
 
     const cliResults = await runCLIAsync(`test ${libName}`);

e2e/node/src/node-esbuild.test.ts

@@ -24,7 +24,7 @@ describe('Node Applications + esbuild', () => {
     const app = uniq('nodeapp');
 
     runCLI(
-      `generate @nx/node:app apps/${app} --bundler=esbuild --no-interactive`
+      `generate @nx/node:app apps/${app} --bundler=esbuild --no-interactive --linter=eslint --unitTestRunner=jest`
     );
 
     checkFilesDoNotExist(`apps/${app}/webpack.config.js`);

e2e/node/src/node-server.test.ts

@@ -80,19 +80,23 @@ describe('Node Applications + webpack', () => {
     const nestApp = uniq('nest');
 
     beforeAll(() => {
-      runCLI(`generate @nx/node:lib libs/${testLib1}`);
-      runCLI(`generate @nx/node:lib libs/${testLib2} --importPath=@acme/test2`);
       runCLI(
-        `generate @nx/node:app apps/${expressApp} --framework=express --port=7000 --no-interactive`
+        `generate @nx/node:lib libs/${testLib1} --linter=eslint --unitTestRunner=jest --buildable=false`
       );
       runCLI(
-        `generate @nx/node:app apps/${fastifyApp} --framework=fastify --port=7001 --no-interactive`
+        `generate @nx/node:lib libs/${testLib2} --importPath=@acme/test2 --linter=eslint --unitTestRunner=jest --buildable=false`
       );
       runCLI(
-        `generate @nx/node:app apps/${koaApp} --framework=koa --port=7002 --no-interactive`
+        `generate @nx/node:app apps/${expressApp} --framework=express --port=7000 --no-interactive --linter=eslint --unitTestRunner=jest --e2eTestRunner=jest`
       );
       runCLI(
-        `generate @nx/node:app apps/${nestApp} --framework=nest --port=7003 --bundler=webpack --no-interactive`
+        `generate @nx/node:app apps/${fastifyApp} --framework=fastify --port=7001 --no-interactive --linter=eslint --unitTestRunner=jest --e2eTestRunner=jest`
+      );
+      runCLI(
+        `generate @nx/node:app apps/${koaApp} --framework=koa --port=7002 --no-interactive --linter=eslint --unitTestRunner=jest --e2eTestRunner=jest`
+      );
+      runCLI(
+        `generate @nx/node:app apps/${nestApp} --framework=nest --port=7003 --bundler=webpack --no-interactive --linter=eslint --unitTestRunner=jest --e2eTestRunner=jest`
       );
 
       addLibImport(expressApp, testLib1);
@@ -165,7 +169,7 @@ describe('Node Applications + webpack', () => {
     const expressApp = 'docker-express-app'; // needs to be consistent for the Dockerfile snapshot
 
     runCLI(
-      `generate @nx/node:app apps/${expressApp} --framework=express --docker --no-interactive`
+      `generate @nx/node:app apps/${expressApp} --framework=express --docker --no-interactive --linter=eslint --unitTestRunner=jest`
     );
 
     checkFilesExist(`apps/${expressApp}/Dockerfile`);
@@ -179,10 +183,10 @@ describe('Node Applications + webpack', () => {
 
     // Set ports to avoid conflicts with other tests that might run in parallel
     runCLI(
-      `generate @nx/node:app apps/${nodeApp1} --framework=none --no-interactive --port=4444`
+      `generate @nx/node:app apps/${nodeApp1} --framework=none --no-interactive --port=4444 --linter=eslint --unitTestRunner=jest`
     );
     runCLI(
-      `generate @nx/node:app apps/${nodeApp2} --framework=none --no-interactive --port=4445`
+      `generate @nx/node:app apps/${nodeApp2} --framework=none --no-interactive --port=4445 --linter=eslint --unitTestRunner=jest`
     );
     updateJson(join('apps', nodeApp1, 'project.json'), (config) => {
       config.targets.serve.options.waitUntilTargets = [`${nodeApp2}:build`];