feat(core): use custom resolution to resolve from source local plugins with artifacts pointing to the outputs #29222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leosvelperez
requested review from
meeroslav,
vsavkin,
mandarini and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Your CI Pipeline Execution ↗ for commit 017b51e ⏳ is in progress.
Last updated at 2024-12-13 15:20:19UTC Sent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
core/local-plugin-custom-resolution
branch
2 times, most recently
from
d1c4fe2 to
dc5ce4a
Compare
jaysoo
approved these changes
Dec 10, 2024
…s with artifacts pointing to the outputs
…elopment condition to resolve local plugins
leosvelperez
force-pushed
the
core/local-plugin-custom-resolution
branch
from
dc5ce4a to
d9bf224
Compare
leosvelperez
commented
Dec 12, 2024
| @@ -138,6 +138,7 @@ export function createNodeFromPackageJson( | |||
| const hash = hashObject({ | |||
| ...json, | |||
| root: projectRoot, | |||
| bust: 1, | |||
There was a problem hiding this comment.
After this PR, with the same file content, a different result is obtained, so we need to bust the cache to ensure projects are processed.
There was a problem hiding this comment.
There should be a comment to explain why this is here and when to update it.
jaysoo
approved these changes
Dec 13, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Local Nx plugins in the new TS setup can't be resolved properly if they aren't built first. Graph plugins can't be built either because the graph is needed to run a task, but the plugin must be built to construct the graph.
Expected Behavior
Local Nx plugins should work in the new TS setup. A custom resolution is added to resolve the local plugin artifacts from the source.
It will try to use a
developmentcondition from theexportsentry inpackage.jsonif it exists. If it doesn't, it will fall back to guess the source based on the artifact path and some commonly known/used source dirs:.,./src,./src/lib.Related Issue(s)
Fixes #