Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): resolve imports from linked workspace projects #29328

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Dec 12, 2024

Current Behavior

When using package manager workspaces and having a dependency between buildable projects that define their entry points in the package.json to point to the outputs, the imports from source files can't be resolved to the corresponding workspace project.

Expected Behavior

When using package manager workspaces and having a dependency between buildable projects that define their entry points in the package.json to point to the outputs, the imports from source files should be resolved to the corresponding workspace project.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Dec 12, 2024
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:01pm

Copy link

nx-cloud bot commented Dec 12, 2024

Your CI Pipeline Execution ↗ for commit 4a3251a ⏳ is in progress.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 8m, 30s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 21s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 0s View ↗
nx-cloud record -- nx format:check --base=48cd5... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 0s View ↗
nx documentation --no-dte ✅ Succeeded 0s View ↗

Last updated at 2024-12-13 16:55:32UTC

Sent with 💌 from NxCloud.

@jaysoo jaysoo marked this pull request as ready for review December 12, 2024 16:54
@jaysoo jaysoo requested review from meeroslav, vsavkin, mandarini and a team as code owners December 12, 2024 16:54
@jaysoo jaysoo requested a review from JamesHenry December 12, 2024 16:54
@leosvelperez leosvelperez force-pushed the core/locate-dep-workspace-linked-project branch from eebf2b8 to 888423a Compare December 13, 2024 13:34
@leosvelperez leosvelperez force-pushed the core/locate-dep-workspace-linked-project branch from 888423a to 4a3251a Compare December 13, 2024 15:57
@leosvelperez leosvelperez requested review from jaysoo and removed request for a team, meeroslav, mandarini and vsavkin December 13, 2024 17:39
@jaysoo jaysoo merged commit 657814c into master Dec 13, 2024
6 checks passed
@jaysoo jaysoo deleted the core/locate-dep-workspace-linked-project branch December 13, 2024 18:36
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants