Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add migration to disable @angular-eslint/prefer-standalone when not set #29164

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Dec 3, 2024

  • Add migration to disable the @angular-eslint/prefer-standalone rule when it's not already set. This prevents a breaking change due to the rule being promoted to the recommended rules in v19.
  • Update the @nx/angular package peer dependencies range to drop Angular v16 and include Angular v20.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #29163

@leosvelperez leosvelperez self-assigned this Dec 3, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner December 3, 2024 11:10
@leosvelperez leosvelperez requested a review from jaysoo December 3, 2024 11:10
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Dec 3, 2024 11:10am

@leosvelperez leosvelperez requested a review from Coly010 December 3, 2024 11:21
@leosvelperez leosvelperez merged commit c62d78d into master Dec 3, 2024
6 checks passed
@leosvelperez leosvelperez deleted the angular/v19-ng-eslint-prefer-standalone-migration branch December 3, 2024 14:30
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/angular 20.2.0-beta.5 still has a peerDependency that enforces < Angular 19
2 participants